53137 - Classic dual menubuttons do not click down properly anymore

Status: VERIFIED FIXED

(SeaMonkey :: Themes, defect, P2)

Description

[Ben Goodger (use ben at mozilla dot org for email)]

back/forward buttons, print button:

clicking the button part should give the active icon, shift the active icon 1px 
down and to the right, and place inset borders around the internal button and 
the dropmarker. 

Now, only the first two things happen, the inset borders are not drawn. This is 
a regression.

Marking major because key toolbar buttons lack a button behaviour in classic.

Comment 1

[Ben Goodger (use ben at mozilla dot org for email)]

this happened between the 14th and the 15th of September. Attempting to hunt it 
down.... 

Comment 2

[Phil Peterson]

nsbeta3-. We tried it and it looks fine.

Comment 3

[Ben Goodger (use ben at mozilla dot org for email)]

nominating for RTM. If this weren't the primary navigation buttons I might be
inclined to agree with the deprioritisation, but this is a major part of the UI.

Comment 4

[don]

Ugh, I just looked and this is worse than I thought.  Making this nsbeta3+.
Ben, if you're gonna fix this, then fix it before the branch.

Comment 5

[Mike Pinkerton (not reading bugmail)]

yeah, buttons not depressing is generally not a good thing from the user
perspective. it looks pretty bad on my latest build.

Comment 6

[Ben Goodger (use ben at mozilla dot org for email)]

This is happening because of the :hover changes landed by joki on the 14th. I 
was apparently depending on incorrect behaviour ;) Adding !important to my 
properties fixes the problem. Preparing a patch...

Comment 7

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: make the border properties in the :hover:active state for the internal button important so that they override the properties imposed by the :hover on the parent

Comment 8

[Ben Goodger (use ben at mozilla dot org for email)]

fix checked in.

Comment 9

[selmer (gone)]

pdt agrees p2.

Comment 10

[Patty Mac]

work ok on all Linux and windows. (2000-09-22-08-M18).
For mac, not sure whether it's fixed yet due to the bug #53805.

Comment 11

[don]

Let's try this for RTM.  Is it really a stop ship?

Comment 12

[Ben Goodger (use ben at mozilla dot org for email)]

The main issue here has been fixed. This was only ever a win/unix problem. 
marking fixed. 

Comment 13

[Patty Mac]

work ok on Mac as well (2000-09-27-11-MN6).

Comment 14

[Patty Mac]

marking verified on all platforms (2000-11-28-08-Mtrunk).