Closed Bug 531459 Opened 10 years ago Closed 10 years ago

Replace XPMs with PNGs as Linux window icons

Categories

(Calendar :: General, defect, minor)

defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: martinschroeder, Assigned: Fallen)

Details

Attachments

(1 file, 1 obsolete file)

XPMs are deprecated, and should be replaced with PNGs! See bug 411494 for the changes SeaMonkey did (a long time ago)!
Attached patch Fix - v1 (obsolete) — Splinter Review
Assignee: nobody → philipp
Status: NEW → ASSIGNED
Attachment #433743 - Flags: review?
Attachment #433743 - Flags: review? → review?(mschroeder)
Comment on attachment 433743 [details] [diff] [review]
Fix - v1

The images need to be converted to png not just renamed!
Attachment #433743 - Flags: review?(mschroeder) → review-
Comment on attachment 433743 [details] [diff] [review]
Fix - v1

Are they not? To keep the xpm history, I converted the .ico file to png, replaced the xpm file with the png file, then hg mv'd the xpm file to png.
(In reply to comment #3)
> (From update of attachment 433743 [details] [diff] [review])
> Are they not? To keep the xpm history, I converted the .ico file to png,
> replaced the xpm file with the png file, then hg mv'd the xpm file to png.

I think the patch didn't apply correctly for me then. I just had a look at the files with the .png extension in a text editor (after I couldn't open them), and they were xpm file format.
Attached patch Fix - v2Splinter Review
Looks like a mercurial bug to me. I couldn't apply my own patch after hg qpop/hg qpushing it. This patch just removes the old files and creates the new ones.
Attachment #433743 - Attachment is obsolete: true
Attachment #433895 - Flags: review?
Attachment #433895 - Flags: review? → review?(mschroeder)
Comment on attachment 433895 [details] [diff] [review]
Fix - v2

r=mschroeder
Attachment #433895 - Flags: review?(mschroeder) → review+
Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/b30f9d91ceeb>

-> FIXED
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
OS: Linux → All
Resolution: --- → FIXED
Target Milestone: --- → 1.0b2
You need to log in before you can comment on or make changes to this bug.