531459 - Replace XPMs with PNGs as Linux window icons

Status: RESOLVED FIXED

(Calendar :: General, defect)

Description

[Martin Schröder [:mschroeder]]

XPMs are deprecated, and should be replaced with PNGs! See bug 411494 for the changes SeaMonkey did (a long time ago)!

Comment 1

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Fix - v1

Comment 2

[Martin Schröder [:mschroeder]]

Comment on attachment 433743 [details] [diff] [review]
Fix - v1

The images need to be converted to png not just renamed!

Comment 3

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 433743 [details] [diff] [review]
Fix - v1

Are they not? To keep the xpm history, I converted the .ico file to png, replaced the xpm file with the png file, then hg mv'd the xpm file to png.

Comment 4

[Martin Schröder [:mschroeder]]

(In reply to comment #3)
> (From update of attachment 433743 [details] [diff] [review])
> Are they not? To keep the xpm history, I converted the .ico file to png,
> replaced the xpm file with the png file, then hg mv'd the xpm file to png.

I think the patch didn't apply correctly for me then. I just had a look at the files with the .png extension in a text editor (after I couldn't open them), and they were xpm file format.

Comment 5

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Fix - v2

Looks like a mercurial bug to me. I couldn't apply my own patch after hg qpop/hg qpushing it. This patch just removes the old files and creates the new ones.

Comment 6

[Martin Schröder [:mschroeder]]

Comment on attachment 433895 [details] [diff] [review]
Fix - v2

r=mschroeder

Comment 7

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/b30f9d91ceeb>

-> FIXED