53149 - Using DOM to add tabs crashes Mozilla.

Status: VERIFIED DUPLICATE of bug 53150

(Core :: DOM: Core & HTML, defect, P3)

Description

[Eric Promislow]

From Bugzilla Helper:
User-Agent: Mozilla/4.0 (compatible; MSIE 5.5; Windows NT 5.0)
BuildID:    2000091312

Adding a tab using tabbox.appendChild() causes stack overflow in rdf.dll

Reproducible: Always
Steps to Reproduce:
1. Load the attached xul file as chrome (I use a debug version of
Mozilla, and have it in packages/komodo/komodo/content/editor/tab.xul).
2. Press the button
3. Pick up the pieces.

Actual Results:  I get the OK/Cancel fatal error dialog box.			
				

Expected Results:  	Added a second tab to the right of the first.  It did
this last week before we moved to the post capabilityID version
of Moz.		

I don't see an attachment field on this page (I'm using the novice thing).
Here's the XUL:

<?xml version="1.0"?>
<!--
Copyright (C) 2000 ActiveState Tool Corporation.  All Rights Reserved.
Contributor(s):
 - Eric Promislow
-->

<?xml-stylesheet href="chrome://global/skin" type="text/css"?>
<?xul-overlay href="chrome://navigator/content/navigatorOverlay.xul"?>
<?xul-overlay href="chrome://navigator/content/navExtraOverlay.xul"?>


<window 
  id="tab-breaker"
  title="Tab Breaker"
  xmlns:html="http://www.w3.org/TR/REC-html40" 
  xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul"
  screenX="100" screenY="100"
>
<script language="javascript">
<![CDATA[
function doTabPick(e) {
  dump("Called doTabPick\n");
}
 
function addTab() {
  var leafName = "flack.txt"
  var newButton = document.createElement('tab');
  newButton.setAttribute("id", "vt1");
  newButton.setAttribute("value", leafName);
  newButton.setAttribute("oncommand", "doTabPick(event);");
  newButton.value = leafName;
  
  var tabbox = document.getElementById('tabbox');
  dump ("About to die here.\n");
  //tabbox.appendChild(newButton);
  tabbox.insertBefore(newButton, tabbox.firstChild);
  dump ("Didn't get this far.\n");
  newButton.setAttribute("selected", "true");
}
]]>
</script>

 <box flex="1" orient="vertical">
   <box id="tabb" flex="1" orient="horizontal">
     <tabcontrol orient="vertical"
         id="tabc"
         index="1" >
       <tabbox id="tabbox" orient="horizontal">
         <tab id="vt0"
              selected="true"
              oncommand="doTabPick(event);"
              value="xyz" />
       </tabbox>
       <tabpanel flex="100%">
         <text value="tab panel #1"/>
       </tabpanel>
     </tabcontrol>

   </box>
   <box orient="horizontal"
        autostretch="never"
        halign="right"
        style="min-width : 10%">
     <button
       id="add_tab"
       value="add tab"
       oncommand="addTab();" />
   </box>
 </box>
</window>

Comment 1

[Johnny Stenback (:jst)]

This is a dupe of bug 53150, right?


*** This bug has been marked as a duplicate of 53150 ***

Comment 2

[John Morrison]

Yep.