Closed Bug 531690 Opened 10 years ago Closed 10 years ago

tp4_xres: intermittent "invalid literal for float()" ValueError:


(Release Engineering :: General, defect)

Not set


(Not tracked)



(Reporter: karlt, Assigned: lsblakk)



(Keywords: intermittent-failure)


(1 file, 1 obsolete file)

Generating results file: tp4_xres: 
		Started Sun, 29 Nov 2009 14:07:24
Traceback (most recent call last):
  File "", line 421, in <module>
  File "", line 403, in test_file
    links = send_to_graph(results_server, results_link, title, date, browser_config, results)
  File "", line 213, in send_to_graph
    result_strings.append(construct_results(machine, counterName, browser_config['branch_name'], browser_config['sourcestamp'], browser_config['buildid'], date, vals))
  File "", line 169, in construct_results
    data_string += "%d,%.2f,%s\n" % (i,float(val), page)
ValueError: invalid literal for float(): 154560681 - File Manager ( PID: 5724 ):	res_base      : ox1c00000	res_mask      : ox1fffff	windows       : 10	GCs           : 64	fonts         : 1	pixmaps       : 5	pictures      : 3	glyphsets     : 0
program finished with exit code 1
Linux mozilla-central talos tp4 on 2009/11/26 20:42:04
Linux mozilla-central talos tp4 on 2009/11/17 23:43:32
Linux mozilla-central talos tp4 on 2009/11/17 18:03:28
Pinged Lukas about this on IRC, she said she'd have a look.
Assignee: nobody → lsblakk
Raises the error to the counter manager whenever total bytes for x resources are not available.
Attachment #415443 - Flags: review?(anodelman)
Comment on attachment 415443 [details] [diff] [review]
Raise error on invalid float value in GetXRes

I don't think that this will do quite what you want, as the float(data) exception will get caught, messaged then raised and caught by the second try.  You probably want a try block containing up till pipe.close() and then a second try block that checks the value collected.
Attachment #415443 - Flags: review?(anodelman) → review-
Attachment #415689 - Flags: review?(anodelman) → review+
Linux mozilla-central talos tp4 on 2009/12/10 12:20:29
(philor and I think this is a case of this bug)
This is now happening on 1.9.2. I don't see it there in the preceding week or so. Perhaps related to something that was recently landed on branch?
Linux mozilla-1.9.2 talos tp4 on 2009/12/14 22:47:37
Linux mozilla-1.9.2 talos tp4 on 2009/12/14 23:25:23
Comment on attachment 415689 [details] [diff] [review]
Raise error on invalid float value in GetXRes with second try block

Checking in;
/cvsroot/mozilla/testing/performance/talos/,v  <--
new revision: 1.5; previous revision: 1.4
Attachment #415689 - Flags: checked-in+
Looks like this hasn't come up again in a couple of weeks.  Closing.
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [orange]
Product: → Release Engineering
You need to log in before you can comment on or make changes to this bug.