531690 - tp4_xres: intermittent "invalid literal for float()" ValueError:

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Karl Tomlinson (:karlt)]

Generating results file: tp4_xres: 
		Started Sun, 29 Nov 2009 14:07:24
Traceback (most recent call last):
  File "run_tests.py", line 421, in <module>
    test_file(arg)
  File "run_tests.py", line 403, in test_file
    links = send_to_graph(results_server, results_link, title, date, browser_config, results)
  File "run_tests.py", line 213, in send_to_graph
    result_strings.append(construct_results(machine, counterName, browser_config['branch_name'], browser_config['sourcestamp'], browser_config['buildid'], date, vals))
  File "run_tests.py", line 169, in construct_results
    data_string += "%d,%.2f,%s\n" % (i,float(val), page)
ValueError: invalid literal for float(): 154560681 - File Manager ( PID: 5724 ):	res_base      : ox1c00000	res_mask      : ox1fffff	windows       : 10	GCs           : 64	fonts         : 1	pixmaps       : 5	pictures      : 3	glyphsets     : 0
program finished with exit code 1

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1259532165.1259533136.5569.gz#err0

Comment 1

[Karl Tomlinson (:karlt)]

Linux mozilla-central talos tp4 on 2009/11/26 20:42:04

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1259296924.1259297944.1041.gz

Comment 2

[Karl Tomlinson (:karlt)]

Linux mozilla-central talos tp4 on 2009/11/17 23:43:32
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1258530212.1258531309.2401.gz
Linux mozilla-central talos tp4 on 2009/11/17 18:03:28
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1258509808.1258510765.32065.gz

Comment 3

[[e-mail] (:bhearsum)]

Pinged Lukas about this on IRC, she said she'd have a look.

Comment 4

[Lukas Blakk [:lsblakk] use ?needinfo]

Attachment: Raise error on invalid float value in GetXRes

Raises the error to the counter manager whenever total bytes for x resources are not available.

Comment 5

[alice nodelman [:alice] [:anode]]

Comment on attachment 415443 [details] [diff] [review]
Raise error on invalid float value in GetXRes

I don't think that this will do quite what you want, as the float(data) exception will get caught, messaged then raised and caught by the second try.  You probably want a try block containing up till pipe.close() and then a second try block that checks the value collected.

Comment 6

[Lukas Blakk [:lsblakk] use ?needinfo]

Attachment: Raise error on invalid float value in GetXRes with second try block

Comment 7

[David Bolter [:davidb] (NeedInfo me for attention)]

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1260476429.1260477455.31289.gz
Linux mozilla-central talos tp4 on 2009/12/10 12:20:29
(philor and I think this is a case of this bug)

Comment 8

[Phil Ringnalda (:philor)]

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1260489077.1260490078.11599.gz

Comment 9

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1260648850.1260649860.1426.gz
Linux mozilla-central talos tp4 on 2009/12/12 12:14:10

Comment 10

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1260650469.1260651412.18497.gz
Linux mozilla-central talos tp4 on 2009/12/12 12:41:09

Comment 11

[Phil Ringnalda (:philor)]

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1260729864.1260730793.5136.gz
Linux mozilla-central talos tp4 on 2009/12/13 10:44:24

Comment 12

[Jonathan Kew [:jfkthame]]

This is now happening on 1.9.2. I don't see it there in the preceding week or so. Perhaps related to something that was recently landed on branch?

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox3.6/1260859657.1260860736.30823.gz
Linux mozilla-1.9.2 talos tp4 on 2009/12/14 22:47:37

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox3.6/1260861923.1260863032.23480.gz
Linux mozilla-1.9.2 talos tp4 on 2009/12/14 23:25:23

Comment 13

[Phil Ringnalda (:philor)]

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1260897930.1260898935.13673.gz
Linux mozilla-central talos tp4 on 2009/12/15 09:25:30

Comment 14

[Zack Weinberg (:zwol)]

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox3.6/1260937609.1260938670.12244.gz
Linux mozilla-1.9.2 talos tp4 on 2009/12/15 20:26:49

Comment 15

[Jonathan Kew [:jfkthame]]

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox3.6/1260989028.1260990122.18119.gz
Linux mozilla-1.9.2 talos tp4 on 2009/12/16 10:43:48

Comment 16

[Phil Ringnalda (:philor)]

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1261065959.1261066993.12273.gz
Linux mozilla-central talos tp4 on 2009/12/17 08:05:59

Comment 17

[Phil Ringnalda (:philor)]

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1261138618.1261139627.10821.gz
Linux mozilla-central talos tp4 on 2009/12/18 04:16:58

Comment 18

[Phil Ringnalda (:philor)]

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox3.5/1261173828.1261174940.28254.gz
Linux mozilla-1.9.1 talos tp4 on 2009/12/18 14:03:48

Comment 19

[Phil Ringnalda (:philor)]

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1261245757.1261246760.16153.gz
Linux mozilla-central talos tp4 on 2009/12/19 10:02:37

Comment 20

[Phil Ringnalda (:philor)]

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox3.6/1261340444.1261341454.29123.gz
Linux mozilla-1.9.2 talos tp4 on 2009/12/20 12:20:44

Comment 21

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 415689 [details] [diff] [review]
Raise error on invalid float value in GetXRes with second try block

Checking in cmanager_linux.py;
/cvsroot/mozilla/testing/performance/talos/cmanager_linux.py,v  <--  cmanager_linux.py
new revision: 1.5; previous revision: 1.4
done

Comment 22

[Lukas Blakk [:lsblakk] use ?needinfo]

Looks like this hasn't come up again in a couple of weeks.  Closing.