Closed Bug 531695 Opened 10 years ago Closed 10 years ago

Update try server factory for recent multi-locale maemo changes

Categories

(Release Engineering :: General, defect, P1)

x86
Linux
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: nthomas, Assigned: armenzg)

References

Details

Attachments

(2 files)

With buildbotcustom@f37c15654c98 and buildbot-configs@0c7260d12d01 we get this on the production try-server master:

-bash-3.1$ buildbot checkconfig
Traceback (most recent call last):
  File "/tools/buildbot-production/lib/python2.5/site-packages/buildbot/scripts/runner.py", line 924, in doCheckConfig
    ConfigLoader(configFile)
  File "/tools/buildbot-production/lib/python2.5/site-packages/buildbot/scripts/checkconfig.py", line 31, in __init__
    self.loadConfig(configFile)
  File "/tools/buildbot-production/lib/python2.5/site-packages/buildbot/master.py", line 529, in loadConfig
    exec f in localDict
  File "master.cfg", line 397, in <module>
    baseWorkDir="%s/build" % SBOX_HOME
  File "/tools/buildbotcustom/buildbotcustom/process/tryserverfactory.py", line 152, in __init__
    MaemoBuildFactory.__init__(self, **kwargs)
TypeError: __init__() takes at least 2 non-keyword arguments (1 given)

The missing arg is baseBuildDir so this is from bug 519684. The exception blocks updating the try server master to the tip's of the two repos.
Assignee: nobody → armenzg
Status: NEW → ASSIGNED
Priority: -- → P1
The patches are being run on staging-try and will ask for review when they go green.
I will continue with this in the morning since the slave seems that it had the wrong keys from previous experimenting on the slave.
http://sm-staging-try-master.mozilla.org:8010/builders/Maemo%20try%20hg%20build/builds/1
Actually, I think try staging dies on upload steps all the time, which is less than ideal but hasn't been a priority.

I think just being able to checkconfig shows that things are better... you can also check the tree to see that the files are in /scratchbox/users/cltbld/home/cltbld/build/upload .
I can see them there:
[cltbld@try-linux-slave05 upload]$ ls -l /scratchbox/users/cltbld/home/cltbld/build/upload
total 43332
-rw-r--r-- 1 cltbld cltbld   557506 Nov 30 17:54 fennec_1.0b6pre_armel.deb
-rw-rw-r-- 1 cltbld cltbld 10956077 Nov 30 17:53 fennec-1.0b6pre.en-US.linux-gnueabi-arm.tar.bz2
-rw-r--r-- 1 cltbld cltbld 11168326 Nov 30 17:54 xulrunner_1.9.3a1pre-20091130162016_armel.deb
-rw-rw-r-- 1 cltbld cltbld 10419297 Nov 30 17:54 xulrunner-1.9.3a1pre.en-US.linux-gnueabi-arm.tar.bz2
-rw-rw-r-- 1 cltbld cltbld 11193449 Nov 30 17:54 xulrunner-1.9.3a1pre.en-US.linux-gnueabi-arm.tests.tar.bz2
but what we wanted to test was that they actually uploaded ;)

Reviews coming.
Attachment #415297 - Flags: review?(aki)
Attachment #415298 - Flags: review?(aki)
Comment on attachment 415297 [details] [diff] [review]
[tryserver configs] add missing baseBuildDir

I think we may even get the WinMo cab->exe fix for free on hg update + reconfig.
Attachment #415297 - Flags: review?(aki) → review+
Attachment #415298 - Flags: review?(aki) → review+
Downgraded the try-master to:
 buildbotcustom:   f7c13427f103
 buildbot-configs: c88560b3cdea
since another change was picked up that affected other builds (https://bugzilla.mozilla.org/show_bug.cgi?id=475382#c26).
Try-master is now running the latest code.

This seems to have been fixed. I will confirm it in the morning.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.