531869 - Maemo multilocale builds should abort on failed locale repacks

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P3)

Description

[[e-mail] (:bhearsum)]

Since the November 28th nightlies these builds have been turning red, but still completing and uploading their builds - so it seems like unnecessary redness.

I asked Armen and he said it looked like string changes causing the problems. Specific errors look like this:
          -s /home/cltbld/build/maemo-1.9.2-nightly/mozilla-1.9.2/mobile/locales/en-US/searchplugins \
          -s /home/cltbld/build/maemo-1.9.2-nightly/releases/l10n-mozilla-1.9.2/it/mobile/searchplugins \
          -t /home/cltbld/build/maemo-1.9.2-nightly/mozilla-1.9.2 -f jar  -c /home/cltbld/build/maemo-1.9.2-nightly/mozilla-1.9.2/objdir/merged/mobile -c /home/cltbld/build/maemo-1.9.2-nightly/releases/l10n-mozilla-1.9.2/it/mobile -c /home/cltbld/build/maemo-1.9.2-nightly/mozilla-1.9.2/mobile/locales/en-US tmp-search.jar.mn
processing tmp-search.jar.mn
Traceback (most recent call last):
  File "/home/cltbld/build/maemo-1.9.2-nightly/mozilla-1.9.2/config/JarMaker.py", line 498, in <module>
    main()
  File "/home/cltbld/build/maemo-1.9.2-nightly/mozilla-1.9.2/config/JarMaker.py", line 495, in main
    localedirs=options.l10n_src)
  File "/home/cltbld/build/maemo-1.9.2-nightly/mozilla-1.9.2/config/JarMaker.py", line 286, in makeJars
    jardir=jardir)
  File "/home/cltbld/build/maemo-1.9.2-nightly/mozilla-1.9.2/config/JarMaker.py", line 231, in makeJar
    localedirs)
  File "/home/cltbld/build/maemo-1.9.2-nightly/mozilla-1.9.2/config/JarMaker.py", line 352, in processJarSection
    outHelper, jf)
  File "/home/cltbld/build/maemo-1.9.2-nightly/mozilla-1.9.2/config/JarMaker.py", line 384, in _processEntryLine
    raise RuntimeError('File "%s" not found in %s' % (src, ', '.join(src_base)))
RuntimeError: File "ebay-it.xml" not found in /home/cltbld/build/maemo-1.9.2-nightly/mozilla-1.9.2/mobile/locales/en-US/searchplugins, /home/cltbld/build/maemo-1.9.2-nightly/releases/l10n-mozilla-1.9.2/it/mobile/searchplugins, /home/cltbld/build/maemo-1.9.2-nightly/mozilla-1.9.2/objdir/mobile/mobile/locales, .
make[1]: *** [searchplugins] Error 1
make[1]: Leaving directory `/home/cltbld/build/maemo-1.9.2-nightly/mozilla-1.9.2/objdir/mobile/mobile/locales'
make: *** [chrome-it] Error 2


If it is indeed just changed strings causing burning we should make these steps non-red (orange, maybe?).

Comment 1

[Axel Hecht [:Pike]]

This is not a string change, but a build bustage, and should be red.

I reopened bug 521996, which actually landed a wrong patch, resolving this as dupe.

Comment 2

[[e-mail] (:bhearsum)]

Why should it be red when the build continues? Red is for fatal things...

Comment 3

[Axel Hecht [:Pike]]

Then it should abort on red.

Comment 4

[Aki Sasaki (not active)]

I think this could be seen as a dup of bug 525327... l10n repacks go red on string issues, but builds go red only on fatal errors.  Splitting the factory would allow for both.

Comment 5

[Armen [:armenzg]]

Futuring until we get to it.

Comment 6

[Chris Cooper [:coop] (he/him)]

Mass move of bugs from Release Engineering:Future -> Release Engineering. See
http://coop.deadsquid.com/2010/02/kiss-the-future-goodbye/ for more details.

Comment 7

[Axel Hecht [:Pike]]

aki, your summary change is not correct, this is about locale errors that are *not* compare-locales.

Comment 8

[Aki Sasaki (not active)]

We should get this for free with bug 525327.

Comment 9

[Aki Sasaki (not active)]

Fixed for nightlies.  Releases are tracked in bug 574764.