Closed Bug 532024 Opened 15 years ago Closed 15 years ago

update accessible tree when accessible reorder event is occurred

Categories

(Other Applications :: DOM Inspector, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: surkov, Assigned: surkov)

References

Details

(Keywords: access)

Attachments

(1 file)

Attached patch patchSplinter Review
When accessible tree is mutation then reorder event is fired on the container of changed accessibles. It's worth to use it to update accessible tree view.
(In reply to comment #0)
> Created an attachment (id=415331) [details]
> patch

the patch is a bit hacky but it sounds it's a simplest way.
Assignee: nobody → surkov.alexander
Status: NEW → ASSIGNED
Attachment #415331 - Flags: superreview?(neil)
Attachment #415331 - Flags: review?(sdwilsh)
Attachment #415331 - Flags: superreview?(neil) → superreview+
Comment on attachment 415331 [details] [diff] [review]
patch

>+    if (node.accessible == accessible) {
>+      // Toggle open state twice to update the children.
>+      this.toggleOpenState(idx);
>+      this.toggleOpenState(idx);
>+      break;
>+    }
Nit: only need to toggle twice if the index was already open.
(Still want to break of course.)
Comment on attachment 415331 [details] [diff] [review]
patch

nit: s/var/let/ please

r=sdwilsh with that change.
Attachment #415331 - Flags: review?(sdwilsh) → review+
landed with addressed Neil's and Shawn's comments - http://hg.mozilla.org/dom-inspector/rev/2f604b4db3d0
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Blocks: DOMi2.0.5
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: