Closed
Bug 532037
Opened 16 years ago
Closed 16 years ago
/mailnews/test/fakeserver/ cause xpcshell-tests fail on JS strict mode
Categories
(MailNews Core :: Backend, defect)
MailNews Core
Backend
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 3.1a1
People
(Reporter: lusian, Assigned: lusian)
References
Details
Attachments
(1 file, 1 obsolete file)
|
3.98 KB,
patch
|
standard8
:
approval-thunderbird3.0.1-
|
Details | Diff | Splinter Review |
line[0] causes tests to hang when line is "".
Attachment #415341 -
Flags: superreview?(bienvenu)
Attachment #415341 -
Flags: review?(bugzilla)
|
||
Updated•16 years ago
|
Attachment #415341 -
Flags: review?(bugzilla) → review+
|
||
Comment 1•16 years ago
|
||
Comment on attachment 415341 [details] [diff] [review]
/mailnews/test/fakeserver/, 0
thx for the patch - can't you use let here:
+ for (var group in this._daemon._groups) {
Attachment #415341 -
Flags: superreview?(bienvenu) → superreview+
|
Assignee | |
Comment 2•16 years ago
|
||
Attachment #415341 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•16 years ago
|
Keywords: checkin-needed
|
|
||
Comment 3•16 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Flags: in-testsuite+
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.1a1
|
||
Comment 4•16 years ago
|
||
Comment on attachment 417070 [details] [diff] [review]
Comment #1
"approval-thunderbird3.0.1=?":
Comment 0 says the patch fixes a (random) hang.
Attachment #417070 -
Flags: approval-thunderbird3.0.1?
|
|
Assignee | |
Comment 5•16 years ago
|
||
(In reply to comment #4)
The hang happens only on strict mode, so the 3.0.1 approval is unnecessary.
|
|
||
Comment 6•16 years ago
|
||
Comment on attachment 417070 [details] [diff] [review]
Comment #1
We don't need this at the moment, we're unlikely to be looking at strict mode on branch.
Attachment #417070 -
Flags: approval-thunderbird3.0.1? → approval-thunderbird3.0.1-
You need to log in
before you can comment on or make changes to this bug.
Description
•