532072 - Conic system-headers are missing when compiling with maemo

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Oleg Romashin (:romaxa)]

../../staticlib/components/libnecko.a(nsMaemoNetworkManager.o): In function `nsMaemoNetworkManager::Startup()':
mozilla/netwerk/system/maemo/nsMaemoNetworkManager.cpp:156: undefined reference to `con_ic_connection_new'
../../staticlib/components/libnecko.a(nsMaemoNetworkManager.o): In function `nsMaemoNetworkManager::CloseConnection()':
mozilla/netwerk/system/maemo/nsMaemoNetworkManager.cpp:122: undefined reference to `con_ic_connection_disconnect'
../../staticlib/components/libnecko.a(nsMaemoNetworkManager.o): In function `connection_event_callback':
mozilla/netwerk/system/maemo/nsMaemoNetworkManager.cpp:76: undefined reference to `con_ic_connection_event_get_status'
../../staticlib/components/libnecko.a(nsMaemoNetworkManager.o): In function `nsMaemoNetworkManager::OpenConnectionSync()':
mozilla/netwerk/system/maemo/nsMaemoNetworkManager.cpp:104: undefined reference to `con_ic_connection_connect'
/scratchbox/compilers/cs2007q3-glibc2.5-i486/bin/../lib/gcc/i486-pc-linux-gnu/4.2.1/../../../../i486-pc-linux-gnu/bin/ld: libxul.so: hidden symbol `con_ic_connection_connect' isn't defined
/scratchbox/compilers/cs2007q3-glibc2.5-i486/bin/../lib/gcc/i486-pc-linux-gnu/4.2.1/../../../../i486-pc-linux-gnu/bin/ld: final link failed: Nonrepresentable section on output
collect2: ld returned 1 exit status
make[5]: *** [libxul.so] Error 1

Comment 1

[Oleg Romashin (:romaxa)]

Attachment: Fast fix

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 415376 [details] [diff] [review]
Fast fix

looks fine to me, but shouldn't this be reviewed by a build system peer?

Comment 3

[Oleg Romashin (:romaxa)]

http://hg.mozilla.org/mozilla-central/rev/ff88f89347e6

Comment 4

[Benjamin Smedberg]

Followup for test bustage: http://hg.mozilla.org/mozilla-central/rev/792a9883a4b4