532174 - run debug unit tests on try servers

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P3)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

The try servers currently run only the old-style ("U" build) unit tests.  They're not running unit tests on the optimized builds or on debug builds.  Debug unit tests in particular are likely to have test failures that don't show up in the other varieties of unit tests.  Therefore try server should run debug unit tests so that people will know from a good cycle on try that their changesets should also go green on mozilla-central.

(Now, if we can, it would probably be good to *not* run the debug unittests on changesets that are on the 1.9.2 or 1.9.1 branches, since they will be orange on those branches.)

(I'm not sure if this bug should also cover running optimized unit tests on try.  If it should, please resummarize.)

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

(In reply to comment #0)
> (Now, if we can, it would probably be good to *not* run the debug unittests on
> changesets that are on the 1.9.2 or 1.9.1 branches, since they will be orange
> on those branches.)

A simple way to do this (for hg pulls) is the following:
hg debugancestor 6cd78a2719be3ded6943e472c60d98d2e46811a1 .
after updating the tree to the revision to be built, or, equivalently:
hg debugancestor 6cd78a2719be3ded6943e472c60d98d2e46811a1 <revision>
if it's after the pull but before the update.

If this command both:

 * returns a success status (0), and

 * returns a string like: "34134:6cd78a2719be3ded6943e472c60d98d2e46811a1" (the part before the ":" can be different, but the part after the ":" can't be)

then the tree is descended from that revision (which is one of the checkins that made debug unittests go green; I'm not sure if it was the last, but it should be close enough).

Otherwise (failure return or other ancestor), the revision to be built is one that we know won't pass unit tests.

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I asked catlee about this (since he recently enabled debug/opt unit tests for Tracemonkey; bug 524176), and he said that doing this for try depends on bug 520227.

Comment 3

[Chris Cooper [:coop] (he/him)]

Future-ing based on dependency.

Comment 4

[Chris Cooper [:coop] (he/him)]

Mass move of bugs from Release Engineering:Future -> Release Engineering. See
http://coop.deadsquid.com/2010/02/kiss-the-future-goodbye/ for more details.

Comment 5

[Lukas Blakk [:lsblakk] use ?needinfo]

Try-as-branch is now live and we have debug unit tests.  Closing.