Closed Bug 532190 Opened 11 years ago Closed 11 years ago

Multiple references to bookmark-item.png which doesn't exist in Modern (.gif does)

Categories

(SeaMonkey :: Themes, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.1a1

People

(Reporter: InvisibleSmiley, Assigned: InvisibleSmiley)

Details

(Keywords: fixed-seamonkey2.0.1, modern)

Attachments

(1 file)

The following affects Trunk an SM 2.0:

http://mxr.mozilla.org/comm-central/search?string=bookmark-item.png&case=on&find=%2Fsuite%2F.*\.[csxhtml]*&findi=&filter=^[^\0]*%24&hitlimit=&tree=comm-central

Ignoring classic, this currently comes down to:
- Help / Appearance Prefs
- Help / Customize Help
- Modern: Session Restore about: page

Simply changing Help will break Classic.

about:sessionrestore should probably be fixed on branch as well.
The help stuff should be fixed by the latest patch in bug 249744. I need to adjust it a bit since I think it's best to only do the "normal" icons.
Let's just fix Modern here then. Patch applies cleanly on both c-c and c-191.
Assignee: nobody → jh
Status: NEW → ASSIGNED
Attachment #415479 - Flags: review?(kairo)
Attachment #415479 - Flags: approval-seamonkey2.0.1?
Comment on attachment 415479 [details] [diff] [review]
gif it is [Checkin: comment 4]

I don't know Modern well enough and I still need to deal with my vacation backlogs, Neil should be a better reviewer here.
Attachment #415479 - Flags: review?(kairo) → review?(neil)
Attachment #415479 - Flags: review?(neil)
Attachment #415479 - Flags: review+
Attachment #415479 - Flags: approval-seamonkey2.0.1?
Attachment #415479 - Flags: approval-seamonkey2.0.1+
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1a1
Flags: in-testsuite-
Keywords: modern
You need to log in before you can comment on or make changes to this bug.