532190 - Multiple references to bookmark-item.png which doesn't exist in Modern (.gif does)

Status: RESOLVED FIXED

(SeaMonkey :: Themes, defect)

Description

[Jens Hatlak (:InvisibleSmiley)]

The following affects Trunk an SM 2.0:

http://mxr.mozilla.org/comm-central/search?string=bookmark-item.png&case=on&find=%2Fsuite%2F.*\.[csxhtml]*&findi=&filter=^[^\0]*%24&hitlimit=&tree=comm-central

Ignoring classic, this currently comes down to:
- Help / Appearance Prefs
- Help / Customize Help
- Modern: Session Restore about: page

Simply changing Help will break Classic.

about:sessionrestore should probably be fixed on branch as well.

Comment 1

[Stefan [:stefanh]]

The help stuff should be fixed by the latest patch in bug 249744. I need to adjust it a bit since I think it's best to only do the "normal" icons.

Comment 2

[Jens Hatlak (:InvisibleSmiley)]

Attachment: gif it is [Checkin: comment 4]

Let's just fix Modern here then. Patch applies cleanly on both c-c and c-191.

Comment 3

[Robert Kaiser]

Comment on attachment 415479 [details] [diff] [review]
gif it is [Checkin: comment 4]

I don't know Modern well enough and I still need to deal with my vacation backlogs, Neil should be a better reviewer here.

Comment 4

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 415479 [details] [diff] [review]
gif it is [Checkin: comment 4]

http://hg.mozilla.org/comm-central/rev/e7199a17fcc4
http://hg.mozilla.org/releases/comm-1.9.1/rev/910bb044e8e3