Multiple references to bookmark-item.png which doesn't exist in Modern (.gif does)

RESOLVED FIXED in seamonkey2.1a1

Status

SeaMonkey
Themes
RESOLVED FIXED
8 years ago
5 years ago

People

(Reporter: InvisibleSmiley, Assigned: InvisibleSmiley)

Tracking

({fixed-seamonkey2.0.1, modern})

Trunk
seamonkey2.1a1
fixed-seamonkey2.0.1, modern
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
The following affects Trunk an SM 2.0:

http://mxr.mozilla.org/comm-central/search?string=bookmark-item.png&case=on&find=%2Fsuite%2F.*\.[csxhtml]*&findi=&filter=^[^\0]*%24&hitlimit=&tree=comm-central

Ignoring classic, this currently comes down to:
- Help / Appearance Prefs
- Help / Customize Help
- Modern: Session Restore about: page

Simply changing Help will break Classic.

about:sessionrestore should probably be fixed on branch as well.

Comment 1

8 years ago
The help stuff should be fixed by the latest patch in bug 249744. I need to adjust it a bit since I think it's best to only do the "normal" icons.
(Assignee)

Comment 2

8 years ago
Created attachment 415479 [details] [diff] [review]
gif it is [Checkin: comment 4]

Let's just fix Modern here then. Patch applies cleanly on both c-c and c-191.
Assignee: nobody → jh
Status: NEW → ASSIGNED
Attachment #415479 - Flags: review?(kairo)
Attachment #415479 - Flags: approval-seamonkey2.0.1?

Comment 3

8 years ago
Comment on attachment 415479 [details] [diff] [review]
gif it is [Checkin: comment 4]

I don't know Modern well enough and I still need to deal with my vacation backlogs, Neil should be a better reviewer here.
Attachment #415479 - Flags: review?(kairo) → review?(neil)

Updated

8 years ago
Attachment #415479 - Flags: review?(neil)
Attachment #415479 - Flags: review+
Attachment #415479 - Flags: approval-seamonkey2.0.1?
Attachment #415479 - Flags: approval-seamonkey2.0.1+
(Assignee)

Comment 4

8 years ago
Comment on attachment 415479 [details] [diff] [review]
gif it is [Checkin: comment 4]

http://hg.mozilla.org/comm-central/rev/e7199a17fcc4
http://hg.mozilla.org/releases/comm-1.9.1/rev/910bb044e8e3
Attachment #415479 - Attachment description: gif it is → gif it is [Checkin: comment 4]
(Assignee)

Updated

8 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Keywords: fixed-seamonkey2.0.1
Resolution: --- → FIXED
(Assignee)

Updated

8 years ago
Target Milestone: --- → seamonkey2.1a1
Flags: in-testsuite-
Keywords: modern
You need to log in before you can comment on or make changes to this bug.