Closed Bug 532194 Opened 15 years ago Closed 14 years ago

Add extra "IT" lines for conditional code so xptcinvoke will compile on Thumb

Categories

(Core :: XPCOM, defect)

ARM
All
defect
Not set
normal

Tracking

()

RESOLVED DUPLICATE of bug 532198

People

(Reporter: reed, Unassigned)

References

Details

Attachments

(1 file)

Attached patch patch - v1Splinter Review
Upstreaming a patch from Kevin Welton <Kevin.Welton@arm.com> to add extra "IT" lines for conditional code so xptcinvoke will compile on Thumb. This comes from http://linux.onarm.com/bugzilla/show_bug.cgi?id=36.
Attachment #415475 - Flags: review?(timeless)
Attachment #415475 - Flags: review?(benjamin)
Attachment #415475 - Flags: review?(vladimir)
Attachment #415475 - Flags: review?(timeless)
Attachment #415475 - Flags: review?(benjamin)
Comment on attachment 415475 [details] [diff] [review]
patch - v1

Looks fine, I'm surprised that this combines as-is into thumb instructions though.
Attachment #415475 - Flags: review?(vladimir) → review+
Comment on attachment 415475 [details] [diff] [review]
patch - v1

get someone to add /* comments */ explaining what the heck those two instructions do.
Attachment #415475 - Flags: review-
this url would have sufficed:
http://infocenter.arm.com/help/topic/com.arm.doc.dui0489b/Cjabicci.html

however the code in question is gone
Status: NEW → RESOLVED
Closed: 14 years ago
OS: Linux → All
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: