Closed Bug 532421 Opened 15 years ago Closed 13 years ago

Duplicate parameter detection should take advantage of known duplicates

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED INCOMPLETE

People

(Reporter: jimb, Unassigned)

Details

With the fix for bug 499524, jsparse.cpp:FunctionDef now reliably has a duplicate argument in hand, regardless of strictness options or modes or the presence of destructuring arguments. jsfun.cpp:Function also always checks for duplicate arguments. JS_CompileUCFunctionForPrincipals does not check, but it probably should.

If JSCUCFFP were fixed, and known duplicates were passed around appropriately so that we could complain after parsing the function body and checking for use strict directives, then CheckStrictFormals would never need to spend time calling fun->findDuplicateFormal, and that could be deleted.
This bug doesn't make much sense in the new world of js::Bindings, or indeed even in the world that it replaced (more packaged up neatly, but still).
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → INCOMPLETE
(In reply to comment #1)
> This bug doesn't make much sense in the new world of js::Bindings, or indeed
> even in the world that it replaced (more packaged up neatly, but still).

Hum, it made sense to me. The information was just lying there; we should have been using it.

Agree this bug should be closed.
You need to log in before you can comment on or make changes to this bug.