532452 - Replace De Mauro search plugin with Hoepli search plugin

Status: VERIFIED FIXED

(Mozilla Localizations :: it / Italian, defect)

Description

[Francesco Lodolo [:flod]]

Attachment: Patch to replace De Mauro with Hoepli

Since the De Mauro Italian dictionary is not available anymore, we need to remove the existing plugin (demauro.xml) from the default set and replace it with a new plugin (hoepli.xml).

Attaching a patch for this purpose, I don't know if we still need an explicit review and keywords (fixed, verified). We'd need to apply this patch to l10n-mozilla-1.9.1 for Firefox 3.5.x.

A mail from Hoepli with the authorization to add the searchplugin has already been sent to Stas.

Comment 1

[Seth Bindernagel]

Comment on attachment 415669 [details] [diff] [review]
Patch to replace De Mauro with Hoepli

I tested this on Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.1.5) Gecko/20091102 Firefox/3.5.5

Looks good.  Flod, please check in your change to your Hg repository and then submit your revision ID to this newsgroup:

http://groups.google.com/group/mozilla.dev.l10n/browse_thread/thread/4b9ad68b32106157/616ab4c030ec7143?lnk=raot#616ab4c030ec7143

Comment 2

[Francesco Lodolo [:flod]]

Thanks Seth, check-ins done. I'll update the opt-in threads as soon as I can test and verify the new plugin.

l10n-mozilla-1.9.1
http://hg.mozilla.org/releases/l10n-mozilla-1.9.1/it/rev/e59da2bec23f

l10n-mozilla-1.9.2
http://hg.mozilla.org/releases/l10n-mozilla-1.9.2/it/rev/fe45ffd817ab

l10n-central
http://hg.mozilla.org/l10n-central/it/rev/5979b619a3e6

Comment 3

[Francesco Lodolo [:flod]]

Verified on both branches and trunk

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; it; rv:1.9.2b5pre) Gecko/20091203 Namoroka/3.6b5pre
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; it; rv:1.9.3a1pre) Gecko/20091203 Minefield/3.7a1pre
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; it; rv:1.9.1.7pre) Gecko/20091203 Shiretoko/3.5.7pre

Comment 4

[Staś Małolepszy :stas]

Reopening to address some questions that emerged regarding Heopli's permission. 

Since timing might be tricky here (3.6 is getting really close to code-completeness), we might take a step back and split this change into two steps:

1. remove De Mauro,
2. add Hoepli.

Step 1 is easy and due to the fact that the De Mauro engine is no longer functional, we might want to do this ASAP, so that we don't ship Italian 3.6 with a broken search plug-in.

Step 2 will require some more communication with Hoepli, and I'm hoping we can figure this out before we freeze 3.6, but in case we don't, we can add them in a point release (3.6.1), so that we don't have to rush right now.

Flod, what do you think? An easy and safe solution would be to remove "hoepli" from list.txt and opt in with that, and then re-add it later. No changes are needed to the plug-in file itself, it can safely stay in the repository for now. 

If that's cool, please go ahead and land this change (remove "hoepli" from list.txt) mentioning my spoken r+ from this comment in the commit message.

We'll be working hard on step 2 in the days/hours to follow.

Thanks!

Comment 5

[Francesco Lodolo [:flod]]

Commit (and opt-in request) done for l10n-mozilla-1.9.2
http://hg.mozilla.org/releases/l10n-mozilla-1.9.2/it/rev/70b67f813cc8

Comment 6

[Staś Małolepszy :stas]

Thanks flod, I've just accepted the opt-in.

Comment 7

[Staś Małolepszy :stas]

Flod, could you make the same change on 1.9.1? We'd like to take it for 3.5.7, so that we don't ship it with a broken search plugin.

Comment 8

[Francesco Lodolo [:flod]]

(In reply to comment #7)
> Flod, could you make the same change on 1.9.1? 

Sure, I should be able to commit and request the opt-in as soon as I get home (less than 12 hours).

Comment 9

[Francesco Lodolo [:flod]]

Commit (and opt-in request) done for l10n-mozilla-1.9.1 too
http://hg.mozilla.org/releases/l10n-mozilla-1.9.1/it/file/34c6d83811fe

Comment 10

[Staś Małolepszy :stas]

Kev, any updates on Hoepli?

Comment 11

[Francesco Lodolo [:flod]]

@Stas

Since the updated permission from Hoepli is fine, can I go on and revert changes (adding hoepli) to list.txt in both releases? Do we need patch+approval?

Comment 12

[Staś Małolepszy :stas]

flod, I trust you know very well how to do this, so please go ahead and land without patches. Please mention this comment in the check-in message, e.g. "r=stas in bug 532452 comment 12".

I'm glad to see that we can finally include Hoepli in Italian Firefox! :)

Comment 13

[Staś Małolepszy :stas]

One more note: we normally don't change search engines in point releases (on stable branches), but since De Mauro has stopped working, I think it's a good idea to add Hoepli to 3.5.x as well. I consider this to be a fix to a broken feature that we had in 3.5.

So, flod, please add Hoepli on 1.9.1 and 1.9.2.

Comment 14

[Francesco Lodolo [:flod]]

> So, flod, please add Hoepli on 1.9.1 and 1.9.2.

Done
http://hg.mozilla.org/releases/l10n-mozilla-1.9.1/it/rev/43140bcd05b6
http://hg.mozilla.org/releases/l10n-mozilla-1.9.2/it/rev/194a57f63f55

In the next hours I'll verify that everything works as expected on nightlies and I'll opt-in with the new changesets.

Thanks a lot Stas ;-)

Comment 15

[Francesco Lodolo [:flod]]

Verified on 

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; it; rv:1.9.1.8pre) Gecko/20091225 Shiretoko/3.5.8pre

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; it; rv:1.9.2b6pre) Gecko/20091225 Namoroka/3.6b6pre

Comment 16

[Nick Thomas [:nthomas] (UTC+12)]

Stas/Axel, if De Mauro is non-functional perhaps we should be removing it on update to a 3.5 or 3.6 release ? I'm currently testing a major update from 3.5.7 to 3.6rc1 and noticed searchplugins/demauro.xml was still present.

Comment 17

[Staś Małolepszy :stas]

Nick: I've just tested a new profile created in 3.5.7 (with De Mauro) which I then opened in 3.6rc1. De Mauro was not there, correctly replaced by Hoepli. I guess a major update works differently? I filed bug 538570 to handle that.

Comment 18

[Staś Małolepszy :stas]

Right, I tested the update and it did work differently. Thanks Nick for spotting that.