Closed Bug 532686 Opened 15 years ago Closed 15 years ago

formfill: unable to use the file picker from imageshack.us

Categories

(Firefox for Android Graveyard :: General, defect)

Fennec 1.1
ARM
All
defect
Not set
major

Tracking

(Not tracked)

VERIFIED FIXED
fennec1.0

People

(Reporter: jmaher, Assigned: vingtetun)

References

Details

(Whiteboard: formfill)

Attachments

(1 file, 2 obsolete files)

this is a regression from the previous beta.  I browse to imageshack.us and click the 'browse' button on the main page which is supposed to open a file picker.

This is on 20091203 on 1.9.2 nightly for both n810 and htc touch pro.
tracking-fennec: --- → ?
Vivien - I think Form Assistant is interfering here.
Attached patch Patch (obsolete) — Splinter Review
Let the event be dispatched for this kind of input
Assignee: nobody → 21
Attachment #415892 - Flags: review?(mark.finkle)
Comment on attachment 415892 [details] [diff] [review]
Patch

>         if (FormHelper.canShowUIFor(element)) {

>+          if (!(element instanceof HTMLInputElement && element.type == "file"))
>+            return;

Should we add this check in FormHelper.canShowUIFor()? I wonder what the ramifications of that change would be. Let me think about it.
Severity: normal → major
Summary: unable to use the file picker from imageshack.us → formfill: unable to use the file picker from imageshack.us
Whiteboard: formfill
Attached patch Patch v0.2 (obsolete) — Splinter Review
Finally, since the exceptions are more usual than what i was thinking at first, i've done as you said : move the code to canShowUIFor and modify one of my previous patch about the input "image" type handling because i think we want to handle it in the prev/next buttons but not on mouse click.
Attachment #415892 - Attachment is obsolete: true
Attachment #416611 - Flags: review?(mark.finkle)
Attachment #415892 - Flags: review?(mark.finkle)
Attached patch right patchSplinter Review
Attachment #416611 - Attachment is obsolete: true
Attachment #416643 - Flags: review?(mark.finkle)
Attachment #416611 - Flags: review?(mark.finkle)
Attachment #416643 - Flags: review?(mark.finkle) → review+
pushed:
https://hg.mozilla.org/mobile-browser/rev/b05200e571c8
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → Post-B5
verified FIXED on builds:

Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2b5pre) Gecko/20091209 Firefox/3.6b5pre Fennec/1.0b6pre

and

Mozilla/5.0 (X11; U; Linux armv6l; Nokia N8xx; en-US; rv:1.9.3a1pre) Gecko/20091209 Firefox/3.7a1pre Fennec/1.0b5
Status: RESOLVED → VERIFIED
Flags: in-litmus?
litmus testcase 9795 has been created to regression test this bug.
Flags: in-litmus? → in-litmus+
I was wrong https://litmus.mozilla.org/show_test.cgi?id=7907 was already in our smoketests.
tracking-fennec: ? → ---
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: