Closed
Bug 532686
Opened 15 years ago
Closed 15 years ago
formfill: unable to use the file picker from imageshack.us
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
fennec1.0
People
(Reporter: jmaher, Assigned: vingtetun)
References
Details
(Whiteboard: formfill)
Attachments
(1 file, 2 obsolete files)
1.79 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
this is a regression from the previous beta. I browse to imageshack.us and click the 'browse' button on the main page which is supposed to open a file picker. This is on 20091203 on 1.9.2 nightly for both n810 and htc touch pro.
Reporter | ||
Updated•15 years ago
|
tracking-fennec: --- → ?
Comment 1•15 years ago
|
||
Vivien - I think Form Assistant is interfering here.
Assignee | ||
Comment 2•15 years ago
|
||
Let the event be dispatched for this kind of input
Assignee: nobody → 21
Attachment #415892 -
Flags: review?(mark.finkle)
Comment 3•15 years ago
|
||
Comment on attachment 415892 [details] [diff] [review] Patch > if (FormHelper.canShowUIFor(element)) { >+ if (!(element instanceof HTMLInputElement && element.type == "file")) >+ return; Should we add this check in FormHelper.canShowUIFor()? I wonder what the ramifications of that change would be. Let me think about it.
Updated•15 years ago
|
Severity: normal → major
Summary: unable to use the file picker from imageshack.us → formfill: unable to use the file picker from imageshack.us
Whiteboard: formfill
Assignee | ||
Comment 5•15 years ago
|
||
Finally, since the exceptions are more usual than what i was thinking at first, i've done as you said : move the code to canShowUIFor and modify one of my previous patch about the input "image" type handling because i think we want to handle it in the prev/next buttons but not on mouse click.
Attachment #415892 -
Attachment is obsolete: true
Attachment #416611 -
Flags: review?(mark.finkle)
Attachment #415892 -
Flags: review?(mark.finkle)
Assignee | ||
Comment 6•15 years ago
|
||
Attachment #416611 -
Attachment is obsolete: true
Attachment #416643 -
Flags: review?(mark.finkle)
Attachment #416611 -
Flags: review?(mark.finkle)
Updated•15 years ago
|
Attachment #416643 -
Flags: review?(mark.finkle) → review+
Comment 7•15 years ago
|
||
pushed: https://hg.mozilla.org/mobile-browser/rev/b05200e571c8
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → Post-B5
Comment 8•15 years ago
|
||
verified FIXED on builds: Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2b5pre) Gecko/20091209 Firefox/3.6b5pre Fennec/1.0b6pre and Mozilla/5.0 (X11; U; Linux armv6l; Nokia N8xx; en-US; rv:1.9.3a1pre) Gecko/20091209 Firefox/3.7a1pre Fennec/1.0b5
Status: RESOLVED → VERIFIED
Updated•15 years ago
|
Flags: in-litmus?
Comment 9•15 years ago
|
||
litmus testcase 9795 has been created to regression test this bug.
Flags: in-litmus? → in-litmus+
Comment 10•15 years ago
|
||
I was wrong https://litmus.mozilla.org/show_test.cgi?id=7907 was already in our smoketests.
Updated•10 years ago
|
tracking-fennec: ? → ---
You need to log in
before you can comment on or make changes to this bug.
Description
•