532776 - Remove Yahoo search from the default search provider set

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Madhava Enros [:madhava]]

The original intention was for yahoo local search to be included here.  Instead, it's yahoo regular search, given the geolocation issues.  We should remove this, to make room for other search providers.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Looks like this might cause some l10n pain...

http://mxr.mozilla.org/l10n-mozilla1.9.2/search?string=yahoo&find=list.txt&findi=&filter=mobile&hitlimit=&tree=l10n-mozilla1.9.2

shows fa and id listing yahoo, which we'd need to remove to avoid busting their builds. The other yahoo variants should probably just be left alone, I guess.

Comment 2

[Axel Hecht [:Pike]]

The easiest way to do this is to just remove yahoo from list.txt and to not hg remove the actual xml file.

Comment 3

[Staś Małolepszy :stas]

I second Pike's approach. It the easiest way right now. I can prepare a patch.

Comment 4

[Staś Małolepszy :stas]

Attachment: Remove Yahoo

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 416135 [details] [diff] [review]
Remove Yahoo

>diff --git a/locales/en-US/chrome/region.properties b/locales/en-US/chrome/region.properties

> # Search engine order (order displayed in the search bar dropdown)s
> browser.search.order.1=Google
>-browser.search.order.2=Yahoo
>+browser.search.order.2=Wikipedia

Do we actually want this? Not sure there's a good reason to treat Wikipedia specially, unless we think it's somehow more useful than the other two engines (amazon and twitter). Could just remove this line as well... Guess I don't feel strongly either way.

Comment 6

[Staś Małolepszy :stas]

Attachment: Remove Yahoo, don't set browser.search.order.2

Agree. Removing browser.search.order.2 altogether seems like a more proper solution.

Comment 7

[Staś Małolepszy :stas]

Landed: http://hg.mozilla.org/mobile-browser/rev/4cad348ac302

Thanks!

Comment 8

[Aakash Desai [:aakashd]]

verified FIXED on builds:

Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2b5pre) Gecko/20091209 Firefox/3.6b5pre Fennec/1.0b6pre

and

Mozilla/5.0 (X11; U; Linux armv6l; Nokia N8xx; en-US; rv:1.9.3a1pre) Gecko/20091209 Firefox/3.7a1pre Fennec/1.0b5

Comment 9

[Al Billings [:abillings - ex-MoCo]]

I don't think that we need a testcase to verify the removal of Yahoo from the list. The bug has been verified and it won't come back in new profiles.