533007 - POP: Login failed dialog "Retry" option doesn't work properly

Status: RESOLVED FIXED

(MailNews Core :: Networking: POP, defect)

Description

[Ben Bucksch (:BenB)]

Reproduction:
1. Delete password in password manager
2. Get Mail for POP account
3. Enter "nonsense" as password at the passwort prompt
   Check [ ] Remember password or not, it makes no difference IIRC.
4. Confirm the auth failure msg dialog
5. In the "Login failed" dialog, there are buttons:
   [ New password ] [ Cancel ] [ Retry ]
   Click "Retry"

Actual result:
A password prompt comes up.
I.e. "New password" and "Retry" effectively do the same.

Expected result:
The same password is tried again.
No password prompt comes up.
If I wanted that, I would have clicked "New password".

Comment 1

[Ben Bucksch (:BenB)]

Fixed by patch in bug 525238.

Comment 2

[Mark Banner (:standard8)]

> 3. Enter "nonsense" as password at the passwort prompt
>    Check [ ] Remember password or not, it makes no difference IIRC.

I'm pretty sure this does make a difference, as remember password being checked is what test_pop3PasswordFailure.js tests.

How easy would it be to separate out just that part of the patch?

I would potentially take a fix for 3.0.1, though does this only happen if the server hasn't been successfully logged into yet? (in other words, if we log into the server in a session, and then there is an error, does retry work correctly?).

btw, Assuming my testcase is right for when we remember the password, I think a testcase for this specific bug would be easy - duplicate test_pop3PasswordFailure.js and in promptPasswordPS set aCheckState.value to false rather than true.

Comment 3

[Mark Banner (:standard8)]

(In reply to comment #2)
> btw, Assuming my testcase is right for when we remember the password, I think a
> testcase for this specific bug would be easy - duplicate
> test_pop3PasswordFailure.js and in promptPasswordPS set aCheckState.value to
> false rather than true.

Hmm, maybe I was wrong and the test doesn't quite ensure we don't get reprompted for the retry case, but it should still be easy to base a test on that file.

Comment 4

[Mark Banner (:standard8)]

(In reply to comment #2)
> > 3. Enter "nonsense" as password at the passwort prompt
> >    Check [ ] Remember password or not, it makes no difference IIRC.
> 
> I'm pretty sure this does make a difference, as remember password being checked
> is what test_pop3PasswordFailure.js tests.
> 
> How easy would it be to separate out just that part of the patch?
> 
> I would potentially take a fix for 3.0.1, though does this only happen if the
> server hasn't been successfully logged into yet? (in other words, if we log
> into the server in a session, and then there is an error, does retry work
> correctly?).

BenB: ping for response

Comment 5

[Ben Bucksch (:BenB)]

> Fixed by patch in bug 525238.

FIXED

Comment 6

[Ben Bucksch (:BenB)]

> How easy would it be to separate out just that part of the patch?

Hard, IIRC

Comment 7

[Mark Banner (:standard8)]

Cancelling status flag as it looks like this would be too much to get into 3.0.x