533121 - Support Google Code for see_also urls

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, enhancement)

Description

[timeless]

steps:
1. load bug 527382
2. paste http://code.google.com/p/gnome2-globalmenu/issues/detail?id=462 into the see also field
3. press enter

expected results:
http://code.google.com/p/gnome2-globalmenu/issues/detail?id=462 is added as a see also link. "Lots of projects use code.google.com"

actual results:
an error that says the url is not a valid bugzilla url.

Comment 1

[Reed Loden [:reed]]

http://googlecode.blogspot.com/2009/10/issue-tracker-data-api-for-project.html has details on Google Code's Issuer Tracker API.

Comment 2

[Reed Loden [:reed]]

Attachment: patch - v1

Probably something like this, but I haven't tested any of this at all, and I'm not 100% sure, so not requesting review.

Comment 3

[Max Kanat-Alexander]

Once the entire See Also system is implemented for the two systems we currently
support, adding additional systems can be considered.

Comment 4

[Frédéric Buclin]

Comment on attachment 416304 [details] [diff] [review]
patch - v1

>+        if ($uri->path =~ m|^p/([^/]+)/issues/detail$|) {

$uri->path is of the form /p/PROJECT_NAME/issues/detail, so you must fix your regexp and add a / before p:

  m|^/p/([^/]+)/issues/detail$|

Otherwise works fine. r=LpSolit

Comment 5

[Frédéric Buclin]

Should be taken for 3.6, IMO.

Comment 6

[Max Kanat-Alexander]

  Okay. You're making my life more difficult for improving the See Also system, though. (I would prefer to improve it and then add additional trackers, which would be a better software engineering practice.)

Comment 7

[Reed Loden [:reed]]

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/
modified Bugzilla/Bug.pm
Committed revision 7103.

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/3.6/
modified Bugzilla/Bug.pm
Committed revision 7061.

Comment 8

[Reed Loden [:reed]]

As per IRC, make regex for matching "code.google.com" case-insensitive. r=mkanat over IRC.

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/
modified Bugzilla/Bug.pm
Committed revision 7104.

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/3.6/
modified Bugzilla/Bug.pm
Committed revision 7063.