Closed Bug 533121 Opened 15 years ago Closed 14 years ago

Support Google Code for see_also urls

Categories

(Bugzilla :: Creating/Changing Bugs, enhancement)

3.4.4
enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
Bugzilla 3.6

People

(Reporter: timeless, Assigned: reed)

References

(Depends on 1 open bug, )

Details

Attachments

(1 file)

steps:
1. load bug 527382
2. paste http://code.google.com/p/gnome2-globalmenu/issues/detail?id=462 into the see also field
3. press enter

expected results:
http://code.google.com/p/gnome2-globalmenu/issues/detail?id=462 is added as a see also link. "Lots of projects use code.google.com"

actual results:
an error that says the url is not a valid bugzilla url.
Version: 3.5.2 → 3.4.4
http://googlecode.blogspot.com/2009/10/issue-tracker-data-api-for-project.html has details on Google Code's Issuer Tracker API.
Attached patch patch - v1Splinter Review
Probably something like this, but I haven't tested any of this at all, and I'm not 100% sure, so not requesting review.
Assignee: create-and-change → reed
Status: NEW → ASSIGNED
Summary: Can't use code.google.com for see also urls → Support Google Code for see_also urls
Once the entire See Also system is implemented for the two systems we currently
support, adding additional systems can be considered.
Depends on: bz-seealso
Attachment #416304 - Flags: review?(LpSolit)
Comment on attachment 416304 [details] [diff] [review]
patch - v1

>+        if ($uri->path =~ m|^p/([^/]+)/issues/detail$|) {

$uri->path is of the form /p/PROJECT_NAME/issues/detail, so you must fix your regexp and add a / before p:

  m|^/p/([^/]+)/issues/detail$|

Otherwise works fine. r=LpSolit
Attachment #416304 - Flags: review?(LpSolit) → review+
Should be taken for 3.6, IMO.
Flags: approval?
Flags: approval3.6?
  Okay. You're making my life more difficult for improving the See Also system, though. (I would prefer to improve it and then add additional trackers, which would be a better software engineering practice.)
Flags: approval?
Flags: approval3.6?
Flags: approval3.6+
Flags: approval+
Target Milestone: --- → Bugzilla 3.6
Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/
modified Bugzilla/Bug.pm
Committed revision 7103.

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/3.6/
modified Bugzilla/Bug.pm
Committed revision 7061.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
As per IRC, make regex for matching "code.google.com" case-insensitive. r=mkanat over IRC.

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/
modified Bugzilla/Bug.pm
Committed revision 7104.

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/3.6/
modified Bugzilla/Bug.pm
Committed revision 7063.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: