strip busted tbird support

RESOLVED FIXED in 1.0

Status

RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: mconnor, Assigned: mconnor)

Tracking

unspecified
Points:
---
Bug Flags:
blocking-weave1.0 +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

9 years ago
We should figure out what, if anything, should be synced with Thunderbird, but not for 1.0.
Flags: blocking-weave1.0+
(Assignee)

Comment 1

9 years ago
http://hg.mozilla.org/labs/weave/rev/5519943c948d

If there's interest in doing something interesting here at some point, someone should file a bug.
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
The sync.xul change broke SeaMonkey integration. :-(

Clicking on the Weave status bar entry in SeaMonkey (using left or right mouse click) now triggers this in the Error Console with Weave 1.0b3:

Error: menuPopup is null
Source: chrome://weave/content/sync.js
Line: 381

which is
  if (menuPopup.parentNode != menuButton)
where menuPopup is
  var menuPopup = document.getElementById('sync-menu-popup');
cf. sync.xul for the rest.

Granted, the comment said it's only for TB...

Mike, can you please revert that change (adapting the comment to read SeaMonkey)? I have no Weave source tree around so it would require me some time to prepare a clean patch.

Comment 3

9 years ago
Created attachment 417271 [details] [diff] [review]
patch Sv1.0 Fix SeaMonkey breakage.

This fixes the SeaMonkey Tools menu item for me.
Attachment #417271 - Flags: review?(mconnor)
(Assignee)

Comment 4

9 years ago
Comment on attachment 417271 [details] [diff] [review]
patch Sv1.0 Fix SeaMonkey breakage.

Heh, oops.
Attachment #417271 - Flags: review?(mconnor) → review+

Updated

9 years ago
Keywords: checkin-needed
Keywords: checkin-needed
You need to log in before you can comment on or make changes to this bug.