533628 - Rank column in Topcrashers CSV output starts with 0 instead of 1

Status: VERIFIED FIXED

(Socorro :: General, task)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

STR:

1) Visit http://crash-stats.mozilla.com/topcrasher/byversion/Camino/2.0.1
2) Note that the "Rank" column starts with 1 for the first row and ends with 300 for the last row
3) Scroll down to the bottom of the page and download the CSV: http://crash-stats.mozilla.com/topcrasher/byversion/Camino/2.0.1?format=csv
4) Open the CSV in your favorite text editor or spreadsheet
5) Observe the value in the rank column for the first (and subsequent) row(s)

ER: Value starts at 1 and goes to 300
AR: Value starts as 0 and goes to 299

Comment 1

[Lonnen :lonnen]

Active link to use instead of the one above:
https://crash-stats.mozilla.com/topcrasher/byversion/Firefox/

Comment 2

[Gabriela Thumé]

Yes, to reproduce I am using:

https://crash-stats.mozilla.com/topcrasher/byversion/Firefox/20.0.1 (report)
https://crash-stats.mozilla.com/topcrasher/byversion/Firefox/20.0.1?format=csv (download csv)

Comment 3

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro-crashstats

https://github.com/mozilla/socorro-crashstats/commit/54bf90009653ba34e51b0bde8dcb39c5ca3afd5c
Failing test to bug #533628

https://github.com/mozilla/socorro-crashstats/commit/601f7e29aca3c7b8d04db7cbbe1c1f3c87394150
Skip to failure test

Using SkipTest to run failure test to bug #533628

https://github.com/mozilla/socorro-crashstats/commit/ecb5c6dff33f5060f985627b1a6241165ab2fb43
bug 533628 failing test merge fix

Comment 4

[Selena Deckelmann :selenamarie :selena]

Oops, just the test was committed. We need a bugfix too! :D

Comment 5

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro-crashstats

https://github.com/mozilla/socorro-crashstats/commit/6672f782872c9ce5473cc25bdfe7f0e0d8d3954a
bug 533628 - Rank column in Topcrashers CSV

https://github.com/mozilla/socorro-crashstats/commit/71386acde5bc622f44ca22e7c27c506d7d19af08
Merge pull request #418 from GabiThume/bug533628

fixes bug 533628 - Rank column in Topcrashers CSV

Comment 6

[Matt Brandt [:mbrandt]]

QA verified on stage - the count is 301 if you include the header row

https://crash-stats.allizom.org/topcrasher/products/Firefox/versions/22.0?format=csv