gloda relies on getting an online state change notification to suppress indexing while offline (offline is used as a proxy for battery use). If I startup without a network connection, gloda seems to miss or not get the notification.
is this all OS? (don't have a handy test box ATM)
probably it's all OS.
This is likely to be perceived as a regression of sorts by laptop users, so marking as blocking 3.1 and aiming at rc1.
Created attachment 427114 [details] [diff] [review] The fix This just checks the online/offline state when gloda is initialised and sets suppression of indexing if required. Admittedly I've not done extensive testing to check that this works correctly, but from what I can tell whilst generating the unit test, this does what we expect for this case.
Comment on attachment 427114 [details] [diff] [review] The fix Yes, this is right, thank you. The unit test didn't need to try and chain off of another set of unit tests; I fixed that and pushed it: http://hg.mozilla.org/comm-central/rev/768179c0a19d
I decree this low risk to take on 3.0.x if you want it there too. (I actually tested this on a 1.9.1 build because everything else is exploding.)
Comment on attachment 427114 [details] [diff] [review] The fix Yeah, I thought it was low risk as well. Putting on the list to consider for approvals.
Correcting 3.1 flags because this landed in time for beta 1.
Comment on attachment 427114 [details] [diff] [review] The fix Two people agree this is low risk, so we'll take it on 3.0.4.
Checked into 1.9.1: http://hg.mozilla.org/releases/comm-1.9.1/rev/bc021a0272a8
For some reason, the test was failing permanently on Windows (on just 3.0), therefore I've backed it out for now and will look again later: http://hg.mozilla.org/releases/comm-1.9.1/rev/befe8ee0f4e7
After some testing, we added a change to the unit test to disable automatic management of offline mode (with r=asuth over irc): http://hg.mozilla.org/comm-central/rev/79666fdca182 Hence now landed on branch as well: http://hg.mozilla.org/releases/comm-1.9.1/rev/dd3eb945ce6e http://hg.mozilla.org/releases/comm-1.9.1/rev/b8e06312e645
on Mozilla/5.0 (Windows; U; Windows NT 5.1; gl; rv:18.104.22.168) Gecko/20100317 Thunderbird/3.0.4 I did the following : -> deleted the database -> Started thunderbird. Activity manager still one item telling me that we are trying to determine which message to index.Shall I raise a new bug for that ?