534202 - Install Plugin Name box is never editable (disabled in XUL)

Status: RESOLVED FIXED

(Other Applications Graveyard :: ChatZilla, defect)

Description

[James Ross]

Silly thing missed (by me) on the Install Plugin dialog: the name <textbox> has disabled="true" in XUL but the code only sets/removed readonly="true", which results in it never being editable.

I must say, though, readonly="true" (without disabled) looks shit in Firefox 3.5.5 on Windows 7 - it looks exactly like an editable textbox!

I'm not actually fussed which attribute we use (but disabled looks better here), but it must be the same in XUL and the code.

Comment 1

[James Ross]

Attachment: Use disabled everywhere

Comment 2

[:Gijs (he/him)]

Comment on attachment 417101 [details] [diff] [review]
Use disabled everywhere

(In reply to comment #0)
> I must say, though, readonly="true" (without disabled) looks shit in Firefox
> 3.5.5 on Windows 7 - it looks exactly like an editable textbox!

Gah, I suspected that was why it used that, but neglected to check. Blegh.

r=me, anyway.

Comment 3

[James Ross]

Pushed --> FIXED.

Comment 4

[James Ross]

Comment on attachment 417101 [details] [diff] [review]
Use disabled everywhere

Setting r+ as was intended to clear from my review queue.