534245 - Premature class resolution while JITting OP_newclass

Status: RESOLVED FIXED

(Tamarin Graveyard :: Baseline JIT (CodegenLIR), defect)

Description

[Stan Switzer]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1.5) Gecko/20091102 Firefox/3.5.5
Build Identifier: 

Cannot resolve signatures now because that could cause a premature verification failure, one that should occur in the class's script-init.

Reproducible: Always

Steps to Reproduce:
Construct a class defined in another script in a dead path of a method.  The class contains references to unavailable types so that it contains verify errors.
Actual Results:  
VerifyError while Jitting OP_newclass

Expected Results:  
Should not get a VerifyError unless the class's script-init is called.

Flash bug 2417298

Comment 1

[Stan Switzer]

Attachment: Patch submission

Watson bug 2417298
P4 changelist 614093

Note: checking ctraits->itaits and ctraits->itraits->init for non-null should not be necessary if ctraits really is a class traits.  But I couldn't convince myself that it absolutely had to be.

Needs a Tamarin test case.

Comment 2

[Edwin Smith]

This patch landed in tamarin quite some time ago; marking fixed.  Still needs a test case.