Closed Bug 534308 Opened 15 years ago Closed 15 years ago

Request needed for jsshell

Categories

(Core :: JavaScript Engine, defect)

x86
Windows 7
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Tracking Status
blocking1.9.2 --- needed
status1.9.2 --- .7-fixed
blocking1.9.1 --- needed
status1.9.1 --- .11-fixed

People

(Reporter: bent.mozilla, Assigned: bent.mozilla)

References

Details

(Keywords: regression)

Attachments

(1 file)

Attached patch PatchSplinter Review
See patch.
Attachment #417172 - Flags: review?(jorendorff)
Comment on attachment 417172 [details] [diff] [review]
Patch

Good ol' scatter.
Attachment #417172 - Flags: review?(jorendorff) → review+
Pushed changeset ea06f16ef9e7 to mozilla-central.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
The bug is regression from the bug 534051. Thus we need the patch from the attachment 0 on the branches where the bug 534051 has landed as the regression prevents running any test cases that involves the scatter function from js shell.
Blocks: 534051
blocking1.9.1: --- → ?
blocking1.9.2: --- → ?
blocking1.9.1: ? → needed
blocking1.9.2: ? → needed
Keywords: regression
Ben, Igor: does this patch work on the branches or will we need new ones? Please add approval requests as appropriate.
Comment on attachment 417172 [details] [diff] [review]
Patch

The patch applies as-is on branches.
Attachment #417172 - Flags: approval1.9.2.5?
Attachment #417172 - Flags: approval1.9.1.11?
Comment on attachment 417172 [details] [diff] [review]
Patch

Approved for 1.9.2.5 and 1.9.1.11, a=dveditz for release-drivers
Attachment #417172 - Flags: approval1.9.2.5?
Attachment #417172 - Flags: approval1.9.2.5+
Attachment #417172 - Flags: approval1.9.1.11?
Attachment #417172 - Flags: approval1.9.1.11+
Attachment #417172 - Flags: approval1.9.2.5+ → approval1.9.2.6+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: