53432 - menus using wrong colors

Status: VERIFIED DUPLICATE of bug 57429

(SeaMonkey :: Themes, defect, P5)

Description

[fantasai]

Overview:
	 - The menu bar in the Classic skin is using 'ThreeDFace', not 'Menu' as
	   its background color.
	 - The menu bar in the Classic skin needs to set the CSS 'color' 
	   property to 'MenuText'. (It is currently left unspecified.)
	 - The menupopup background also needs to be changed from 'ThreeDFace'
	   to 'Menu', especially because it already uses 'MenuText' for its 
	   text.

I haven't been able to test these changes because I don't know where the 
menu.css Mozilla uses is located. (I've found a menu.css in the Classic 
directory, but changes in it don't affect the chrome at all.) However, I think 
this should be an easy fix.

Comment 1

[hangas]

Nice, thanks.  Sending to Joe.

Comment 2

[Joe Hewitt (gone)]

The dithering is actually a part of the skin.  Ben used a transparent 
checkerboard gif over the background of those tabs because he needed to create 
a light color for the background.  He said he couldn't use threedhighlight 
because it clashed with the border of the tab and removed the outset effect.  

Removing the checkerboard would mean we'd either have to use threedhighlight 
and lose the outset look, or perhaps use the lighter color on the selected tab 
which has a bold font and use threedface on the unselected tabs.  

Comment 3

[fantasai]

Are you sure you've got the right bug? This one's about menu text/background 
color, not tabs.

Comment 4

[Joe Hewitt (gone)]

whoops, I posted that to the wrong bug. sorry.

Comment 5

[Joe Hewitt (gone)]

Don't think this will get approved for RTM.  Marking P5 Future.

Comment 6

[fantasai]

Found out how to edit/test chrome files -- here's the fix:
file: skin/classic/global/menu.css

line 1:
menubar 
  {
-    background-color      : threedface;
+    background-color      : menu;
+    color                 : menutext; /*didn't exist*/
  }

~line 30:
/* XXX menupopups have to have a color explicitly specified. this is a bug */
menupopup, popup 
  {
-    background-color      : threedface;
+    background-color      : menu;

Don't know whether this rates as a "patch", but it fixes the problem. :)
Works on build 2000100308 on Windows 2000.

Comment 7

[hangas]

Marking as dup


*** This bug has been marked as a duplicate of 57429 ***

Comment 8

[Diego]

Verified dupe of bug 57429: "Win classic theme should support system colors"