534341 - XPConnect should not unroot globals of non-main thread contexts

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Peter Van der Beken [:peterv]]

Attachment: v1

Since we don't cycle collect contexts that are not on the main thread.

We found this while running the test in bug 531225. Bent says this causes crashes (I killed it before it crashed).

Comment 1

[Peter Van der Beken [:peterv]]

http://hg.mozilla.org/mozilla-central/rev/8f6bdbf8e701

Comment 2

[Johnny Stenback (:jst)]

Comment on attachment 417203 [details] [diff] [review]
v1

+    static inline JSBool IsMainThreadContext(JSContext *cx)
+    {
+        return cx->thread == sMainJSThread;
+    }

We already have IsMainThread(JSContext *cx), maybe just use that? :)

sr=jst with that.

Comment 3

[Peter Van der Beken [:peterv]]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/9cda2f6b9bb0

Comment 4

[Peter Van der Beken [:peterv]]

Attachment: v1

Comment 5

[Daniel Veditz [:dveditz]]

Comment on attachment 417945 [details] [diff] [review]
v1

Approved for 1.9.1.7, a=dveditz for release-drivers

Comment 6

[Peter Van der Beken [:peterv]]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/505f78dd66a4

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Peter, any chance for QA to test this fix with a 3.5.8pre build? Do we have automated tests which cover code lines around the given patch and we can trust?