The default bug view has changed. See this FAQ.

XPConnect should not unroot globals of non-main thread contexts

RESOLVED FIXED in mozilla1.9.2

Status

()

Core
XPConnect
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: peterv, Assigned: peterv)

Tracking

Trunk
mozilla1.9.2
Points:
---
Bug Flags:
blocking1.9.2 +

Firefox Tracking Flags

(status1.9.2 final-fixed, blocking1.9.1 .8+, status1.9.1 .8-fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

v1
735 bytes, patch
peterv
: review+
peterv
: superreview+
Details | Diff | Splinter Review
(Assignee)

Description

7 years ago
Created attachment 417203 [details] [diff] [review]
v1

Since we don't cycle collect contexts that are not on the main thread.

We found this while running the test in bug 531225. Bent says this causes crashes (I killed it before it crashed).
Flags: blocking1.9.2?
Attachment #417203 - Flags: superreview?(jst)
Attachment #417203 - Flags: review?(bent.mozilla)
Attachment #417203 - Flags: review?(bent.mozilla) → review+
(Assignee)

Comment 1

7 years ago
http://hg.mozilla.org/mozilla-central/rev/8f6bdbf8e701
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
blocking1.9.1: ? → .7+
status1.9.1: --- → wanted
Comment on attachment 417203 [details] [diff] [review]
v1

+    static inline JSBool IsMainThreadContext(JSContext *cx)
+    {
+        return cx->thread == sMainJSThread;
+    }

We already have IsMainThread(JSContext *cx), maybe just use that? :)

sr=jst with that.
Attachment #417203 - Flags: superreview?(jst) → superreview+
Flags: blocking1.9.2? → blocking1.9.2+
Whiteboard: [has patch][can land 1.9.2]
(Assignee)

Comment 3

7 years ago
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/9cda2f6b9bb0
status1.9.2: --- → final-fixed
Whiteboard: [has patch][can land 1.9.2]
(Assignee)

Comment 4

7 years ago
Created attachment 417945 [details] [diff] [review]
v1
Attachment #417203 - Attachment is obsolete: true
Attachment #417945 - Flags: superreview+
Attachment #417945 - Flags: review+
Attachment #417945 - Flags: approval1.9.1.7?
Comment on attachment 417945 [details] [diff] [review]
v1

Approved for 1.9.1.7, a=dveditz for release-drivers
Attachment #417945 - Flags: approval1.9.1.7? → approval1.9.1.7+
(Assignee)

Comment 6

7 years ago
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/505f78dd66a4
status1.9.1: wanted → .7-fixed
Peter, any chance for QA to test this fix with a 3.5.8pre build? Do we have automated tests which cover code lines around the given patch and we can trust?
You need to log in before you can comment on or make changes to this bug.