534407 - Crash [@ nsPrintEngine::DoPrint(nsPrintObject*)] while printing

Status: VERIFIED FIXED

(Core :: Printing: Output, defect)

Description

[Antti Tervasmäki]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a1pre) Gecko/20091212 Minefield/3.7a1pre Firefox/3.5.5
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a1pre) Gecko/20091212 Minefield/3.7a1pre Firefox/3.5.5

With some sites selecting print causes now crash like:

http://crash-stats.mozilla.com/report/index/83c1761c-0422-489e-8487-412d82091212

Reproducible: Always

Steps to Reproduce:
1. Go site like given URL
2. click print (on that site "Tulosta")
3. Crash
Actual Results:  
Minefield crashes

Expected Results:  
Printing and browser alive

Yesterdays nightly 091211 is not crashing current 091212 is crashing so this is a new crash.

Comment 1

[timeless]

Signature	nsPrintEngine::DoPrint(nsPrintObject*)
UUID	83c1761c-0422-489e-8487-412d82091212
Time 	2009-12-12 09:40:39.488252
Uptime	1414
Last Crash	7206 seconds before submission
Product	Firefox
Version	3.7a1pre
Build ID	20091212045454
Branch	1.9.3
OS	Windows NT
OS Version	6.1.7600
CPU	x86
CPU Info	AuthenticAMD family 16 model 4 stepping 2
Crash Reason	EXCEPTION_ACCESS_VIOLATION
Crash Address	0x0
User Comments	
Processor Notes 	
Crashing Thread
Frame 	Module 	Signature [Expand] 	Source
0 	xul.dll 	nsPrintEngine::DoPrint 	layout/printing/nsPrintEngine.cpp:2278
1 	xul.dll 	nsPrintEngine::PrintDocContent 	layout/printing/nsPrintEngine.cpp:2138
2 	xul.dll 	nsPrintEngine::PrintDocContent 	layout/printing/nsPrintEngine.cpp:2147
3 	xul.dll 	nsPrintEngine::DonePrintingPages 	layout/printing/nsPrintEngine.cpp:2867
4 	xul.dll 	nsPagePrintTimer::Notify 	layout/printing/nsPagePrintTimer.cpp:93
5 	xul.dll 	nsTimerImpl::Fire 	xpcom/threads/nsTimerImpl.cpp:472
6 	xul.dll 	nsTimerEvent::Run 	xpcom/threads/nsTimerImpl.cpp:519

Comment 2

[Jim Jeffery not reading bug-mail 1/2/11]

Confirming the crash.  For me, Minefield just hard crashed with 'Minefield stopped working' - no crash reporter appeared. 

Using Win7 HP 64bit here.

Maybe caused by: https://bugzilla.mozilla.org/show_bug.cgi?id=487667 ?

Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a1pre) Gecko/20091212 Minefield/3.7a1pre Firefox/3.6 ID:20091212045454

Comment 3

[Jim Jeffery not reading bug-mail 1/2/11]

OK in changeset: http://hg.mozilla.org/mozilla-central/rev/9af2a428dcb1
broken in cset: http://hg.mozilla.org/mozilla-central/rev/180966423a3c

The broken cset is the patch as noted above in comment 2

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Yeah, it is not very unexpected that the clone-doc-for-printing causes few regressions. I'll look at this tomorrow.

Comment 5

[Bill Gianopoulos [:WG9s]]

I get this crash on Linux as well.

OS -> All

Comment 6

[Jim Jeffery not reading bug-mail 1/2/11]

Another page that crashes hard when printing:
http://www.dwarfnet.com/christmas/parodies/month.shtml

No crash-report, just a hard crash of the browser.

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

Attachment: Don't try to print document which doesn't have printing presentation

This fixes the problem with the original URL (and which this bug is about).

I can't reproduce the problem with http://www.dwarfnet.com/christmas/parodies/month.shtml
Jim, could you file a new bug for that with steps to reproduce.

Comment 8

[Jim Jeffery not reading bug-mail 1/2/11]

(In reply to comment #7)
> Created an attachment (id=417741) [details]
> Don't try to print document which doesn't have printing presentation
> 
> This fixes the problem with the original URL (and which this bug is about).
> 
> I can't reproduce the problem with
> http://www.dwarfnet.com/christmas/parodies/month.shtml
> Jim, could you file a new bug for that with steps to reproduce.

Yes, I'll retest tomorrow, I'm at work now and if needed will refile a new bug.

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Crashes on all platforms:
http://crash-stats.mozilla.com/report/list?query_search=signature&query_type=exact&query=nsPrintEngine%3A%3ADoPrint%28nsPrintObject*%29&date=&range_value=1&range_unit=weeks&do_query=1&signature=nsPrintEngine%3A%3ADoPrint%28nsPrintObject*%29

Tony can also reproduce this bug easily. He could probably test a tryserver build with your patch Olli.

Comment 10

[Tony Chung [:tchung]]

I hit this crash on mac 10.5.8 on trunk nightly, running: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.3a1pre) Gecko/20091214 Minefield/3.7a1pre

My stack: http://crash-stats.mozilla.com/report/index/bp-4b99bbd3-1c9d-46ac-8afc-8e6bc2091214

Frame  	Module  	Signature [Expand]  	Source
0 	XUL 	nsPrintEngine::DoPrint 	layout/printing/nsPrintEngine.cpp:2278
1 	XUL 	XUL@0x732397 	
2 	XUL 	nsPrintEngine::DonePrintingPages 	layout/printing/nsPrintEngine.cpp:2147
3 	XUL 	nsPagePrintTimer::Notify 	layout/printing/nsPagePrintTimer.cpp:93
4 	XUL 	nsTimerImpl::Fire 	xpcom/threads/nsTimerImpl.cpp:430
5 	XUL 	nsTimerEvent::Run 	xpcom/threads/nsTimerImpl.cpp:519
6 	XUL 	nsThread::ProcessNextEvent 	xpcom/threads/nsThread.cpp:527
7 	XUL 	NS_ProcessPendingEvents_P 	nsThreadUtils.cpp:200
8 	XUL 	nsBaseAppShell::NativeEventCallback 	widget/src/xpwidgets/nsBaseAppShell.cpp:121
9 	XUL 	nsAppShell::ProcessGeckoEvents 	widget/src/cocoa/nsAppShell.mm:498
10 	CoreFoundation 	CFRunLoopRunSpecific 	
11 	CoreFoundation 	CFRunLoopRunInMode 	
12 	HIToolbox 	RunCurrentEventLoopInMode 	
13 	HIToolbox 	ReceiveNextEventCommon 	
14 	HIToolbox 	BlockUntilNextEventMatchingListInMode 	
15 	AppKit 	_DPSNextEvent 	
16 	AppKit 	-[NSApplication nextEventMatchingMask:untilDate:inMode:dequeue:] 	
17 	AppKit 	-[NSApplication run] 	
18 	XUL 	nsAppShell::Run 	widget/src/cocoa/nsAppShell.mm:851
19 	XUL 	nsAppStartup::Run 	toolkit/components/startup/src/nsAppStartup.cpp:182
20 	XUL 	XRE_main 	toolkit/xre/nsAppRunner.cpp:3499
21 	firefox-bin 	main 	browser/app/nsBrowserApp.cpp:158
22 	firefox-bin 	firefox-bin@0xbf5 	
23 		@0x3

My repro: 
- set printer to a wireless networked HP Photosmart C6100
- goto www.google.com homepage
- File > Print, watch the printer settings window appear
- Click Print
- 100% crash on trunk.

DOES NOT crash on 1.9.2 nightly

Comment 11

[Olli Pettay [:smaug][[e-mail]]]

http://hg.mozilla.org/mozilla-central/rev/1c71987688fe

Comment 12

[Olli Pettay [:smaug][[e-mail]]]

If you see other crashes, please file new bugs.

Comment 13

[Tony Chung [:tchung]]

Verified fixed on Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.3a1pre) Gecko/20091218 Minefield/3.7a1pre.   The URL here, and google.com no longer crashes and successfully prints.