534423 - Reduce use of Atom in XML/RegExp when more specific types can be used.

Status: VERIFIED FIXED

(Tamarin Graveyard :: Virtual Machine, defect)

Description

[Edwin Smith]

These fields only ever hold String*, so make them DRCWB and it's one less case we need to worry about for encapsulating Atom, and a more specific field declaration anyway is a good thing.

Comment 1

[Edwin Smith]

Attachment: Convert RegExp string constant fields from ATOM_WB to DRCWB(String*)

Comment 2

[Edwin Smith]

Attachment: declare XML notification string constants as DRCWB(Stringp) not ATOM_WB

This change of the "type" parameter from Atom to Stringp ripples through the notification call path (no other types are ever used for that parameter).

Comment 3

[Edwin Smith]

Attachment: E4XNode._equals() should return bool instead of Atom

Straightforward change, one less place using Atom when a plain type works fine.

Comment 4

[Edwin Smith]

Comment on attachment 417276 [details] [diff] [review]
Convert RegExp string constant fields from ATOM_WB to DRCWB(String*)

pushed http://hg.mozilla.org/tamarin-redux/rev/0cf9b5a9378c

Comment 5

[Edwin Smith]

Comment on attachment 417279 [details] [diff] [review]
declare XML notification string constants as DRCWB(Stringp) not ATOM_WB

pushed http://hg.mozilla.org/tamarin-redux/rev/b0059d2b9df4

Comment 6

[Edwin Smith]

Comment on attachment 417281 [details] [diff] [review]
E4XNode._equals() should return bool instead of Atom

pushed http://hg.mozilla.org/tamarin-redux/rev/43b8d8ca1dec

Comment 7

[Chris Peyer]

Engineering work item, marking verified.