Closed Bug 534545 Opened 15 years ago Closed 12 years ago

"Why was this page blocked?" button should not show if the relevant pref is missing or malformed

Categories

(Toolkit :: Safe Browsing, defect)

Product:
Toolkit
Component:
Safe Browsing
Platform:
ARM
All
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED WONTFIX

People

(Reporter: Unfocused, Unassigned)

Details

Currently, when the "Why was this page blocked?" button is pressed and the relevant pref is missing (or malformed), an error will be shown in the error console. This isn't very helpful to the user. Instead, the button should not be shown if the relevant pref is missing or malformed - so that it can never get into a state where the button will do nothing.
Hmm - taking away the button doesn't feel like the best outcome for uses either, though. How about, if the pref is not present, or malformed, we go back to the default branch and get the original? Did you encounter a specific case where this occurred organically?
Which "missing pref"? The URL for getting a report? I don't think that's worth fixing -- it's not intended as a user controllable thing, but rather a lazy way to have per-product URLs.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → WONTFIX
(In reply to Justin Dolske [:Dolske] from comment #2) > Which "missing pref"? browser.safebrowsing.warning.infoURL for phishing, browser.safebrowsing.malware.reportURL for malware. (In reply to Justin Dolske [:Dolske] from comment #2) > I don't think that's > worth fixing -- it's not intended as a user controllable thing, but rather a > lazy way to have per-product URLs. Agreed.
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.