534593 - Cannot delete tasks from Today Pane in Mail tab

Status: RESOLVED FIXED

(Calendar :: Lightning Only, defect)

Description

[pavel.zahradnik]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; cs; rv:1.9.1.5) Gecko/20091102 Firefox/3.5.5
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; cs; rv:1.9.1.5) Gecko/20091204 Lightning/1.0b2pre Thunderbird/3.0

It is impossible to delete tasks in Today Pane from context menu or using DELETE key.
Both above mentioned procedures work for deleting events in Today Pane.

Reproducible: Always

Steps to Reproduce:
1. Select task in Today pane
2. Right click the task and select Delete Task option or hit DELETE key
Actual Results:  
Nothing happens.

Expected Results:  
Selected task should be deleted.

Comment 1

[Martin Schröder [:mschroeder]]

Confirmed using Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1.5) Gecko/20091204 Lightning/1.0b2pre Thunderbird/3.0. But it works for me in the Calendar and Task tab, and in the Mail tab with the backspace key.

Comment 2

[Decathlon]

Seems that isCommandEnabled()  returns a false value for the command "calendar_delete_todo_command" if the command is called from today pane when in mail mode. In fact isCalendarInForeground() is false:
http://mxr.mozilla.org/comm-central/source/calendar/base/content/calendar-common-sets.js#180

The check of isCalendarInForeground() was added with patch for bug 456385

https://hg.mozilla.org/comm-central/diff/ffb301b5cd6b/calendar/base/content/calendar-common-sets.js#l1.78

Comment 3

[Decathlon]

Attachment: proposal

Due to bug 469684, this patch solves only a part of the problem.
It allows to delete tasks with the "Del" key, but not with the context menu entry because when context menu rises, the blur event fires and makes false "this.todo_tasktree_focused" (bug 469684).
Philipp, what's your opinion? Could it be a correct approach (along with a fix for bug 469684) or it needs something completely different?

Comment 4

[Philipp Kewisch [:Fallen][📱📆]]

Comment on attachment 430018 [details] [diff] [review]
proposal

Looks good, r=philipp

Comment 5

[Philipp Kewisch [:Fallen][📱📆]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/e0568fe2a910>
-> FIXED

Comment 6

[pavel.zahradnik]

(In reply to comment #3)
> It allows to delete tasks with the "Del" key, but not with the context menu
> entry because when context menu rises, the blur event fires and makes false
> "this.todo_tasktree_focused" (bug 469684).

Well I cannot consider this bug to be fixed as there is "Delete task" item in the context menu but deleting task from this context menu does not work. Actually in my opinion it won't be usual procedure to select task with mouse click and delete it with keyboard.

Comment 7

[Stefan Sitter [:ssitter]]

(In reply to comment #6)

Already tracked by Bug 567596. Setting back to fixed based on comment #5.