534641 - Selecting Multiple Message Filters to run in other folders

Status: RESOLVED FIXED

(MailNews Core :: Filters, defect)

Description

[Abraham]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.1.5) Gecko/20091102 Firefox/3.5.5
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.1.5) Gecko/20091204 Lightning/1.0b2pre Thunderbird/3.0

I Bring up message filters and try to select 10 or 20 filters that I want to run in a folder (ie.  Old inbox)  I am unable to do so.  This worked in previous versions.

I even tried with no theme addons just incase

Reproducible: Always

Steps to Reproduce:
1. Open Message Filters
2. Try to select more than one using shift or any other method??
3. It simply does not highlight more than one
Actual Results:  
It used to highlight more than one and you could select run selected filters on .....  But now it is one by one.  Very Painful

Expected Results:  
Should be able to select all and search

Comment 1

[Kent James (:rkent)]

I can confirm that this is happening, plus I tested on TB2 and you could select multiple filters there. So this is a regression. I have not idea why though, as there were very few changes to the filter list editor.

Comment 2

[Ludovic Hirlimann [:Usul]]

(In reply to comment #1)
> I can confirm that this is happening, plus I tested on TB2 and you could select
> multiple filters there. So this is a regression. I have not idea why though, as
> there were very few changes to the filter list editor.

Might be a CORE change !

Comment 4

[Kent James (:rkent)]

I hope to at least look at this bug soon, and if I can fix it I'd like it on the branch.

Comment 5

[Kent James (:rkent)]

For the record, I changed this to Mailnews Core/Filters because that's where I look for bugs like this. But the FilterListDialog is forked between SM and TB, and only TB sees this problem.

Comment 6

[Kent James (:rkent)]

Attachment: Could it be this simple?

This simple patch worked on my quick tests.

Comment 7

[Kent James (:rkent)]

Attachment: Naaah, allowing multiple selection exposed a delete bug

Comment 8

[foredoomed]

(In reply to comment #7)
> Created an attachment (id=418934) [details]
> Naaah, allowing multiple selection exposed a delete bug


How can apply patch?

Comment 9

[Magnus Melin [:mkmelin]]

Comment on attachment 418934 [details] [diff] [review]
Naaah, allowing multiple selection exposed a delete bug

Looks good, thx! r=mkmelin

Comment 10

[Kent James (:rkent)]

"How can apply patch?"

Normally you would need a development environment setup for this, so that you can compile mailnews code. Do you have this setup? It is not a trivial task.

If you just want this to work for you, I will land this bug in a day or two, and then you will be able to pick it up in a nightly build.

Comment 11

[Kent James (:rkent)]

Checked into trunk http://hg.mozilla.org/comm-central/rev/c7081c7489e2

Comment 12

[Blake Winton (:bwinton) (:☕️)]

Landed on 1.9.1 as <http://hg.mozilla.org/releases/comm-1.9.1/rev/1e428f88e7b4>.