GCHeap incorrectly handling return from VMPI_reserve

RESOLVED FIXED in Q4 11 - Anza

Status

P2
normal
RESOLVED FIXED
9 years ago
8 years ago

People

(Reporter: bgetlin, Assigned: pnkfelix)

Tracking

unspecified
Q4 11 - Anza
Bug Flags:
flashplayer-bug +

Details

Attachments

(1 attachment)

(Reporter)

Description

9 years ago
User-Agent:       Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 6.0; Trident/4.0; SLCC1; .NET CLR 2.0.50727; Media Center PC 5.0; .NET CLR 3.5.30729; .NET CLR 3.0.30729)
Build Identifier: 

Since the input address to VMPI_Reserve is merely a "hint" at which address to reserve, it may not actually reserve the exact region that we're asking for.  Therefore we need to make sure the returned region is the same as the "asked for" region before assuming the new block is contiguous.

Reproducible: Sometimes
(Reporter)

Comment 1

9 years ago
Created attachment 417497 [details] [diff] [review]
Patch
Attachment #417497 - Flags: review+
(Reporter)

Updated

9 years ago
Attachment #417497 - Flags: review+ → review?(lhansen)
(Reporter)

Updated

9 years ago
Attachment #417497 - Flags: review?(lhansen) → review?(treilly)

Updated

9 years ago
Attachment #417497 - Flags: superreview?(lhansen)
Attachment #417497 - Flags: review?(treilly)
Attachment #417497 - Flags: review+

Comment 2

9 years ago
Brent reports that this is crashy, will hold off on review until that is resolved.

Updated

9 years ago
Attachment #417497 - Flags: superreview?(lhansen) → superreview-

Updated

9 years ago
Component: Virtual Machine → Garbage Collection (mmGC)
Priority: -- → P2
QA Contact: vm → gc
Target Milestone: --- → flash10.1

Updated

9 years ago
Assignee: nobody → bgetlin

Updated

9 years ago
Priority: P2 → --
Target Milestone: flash10.1 → Future

Updated

9 years ago
Priority: -- → P3
Target Milestone: Future → flash10.2

Updated

9 years ago
Blocks: 564119

Updated

8 years ago
Assignee: bgetlin → fklockii
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
(In reply to comment #2)
> Brent reports that this is crashy, will hold off on review until that is
> resolved.

Further info: Brent reports to me that his memory is that after checking in this fix, the Linux smoke builds started crashing intermittently approximately 50% of the time.

Updated

8 years ago
Flags: flashplayer-bug+

Updated

8 years ago
Priority: P3 → P4

Updated

8 years ago
Priority: P4 → P2
Target Milestone: Q3 11 - Serrano → Q4 11 - Anza
(In reply to comment #1)
> Created attachment 417497 [details] [diff] [review] [review]
> Patch

Looks to me like something very much like this patch was already committed in changeset:3459:

  http://hg.mozilla.org/tamarin-redux/rev/5bcf95ed4a0a

(I feel like I'm taking crazy pills; how did I not notice this before?  Did I simply not attempt to apply the patch?)
Fixed by changeset:3459 as noted in comment 4.
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.