Closed Bug 534749 Opened 10 years ago Closed 9 years ago

TM: we try to overflow guard loads

Categories

(Core :: JavaScript Engine, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: gal, Assigned: gal)

References

Details

Attachments

(1 file)

Do I really need to explain why thats a really bad idea?
Blocks: 534378
Attached patch patchSplinter Review
LIR_ov checks for an arithmetic overflow. If we peephole optimized away the arithmetic op, we check the overflow flag in the processor and it might be set to god knows what.

This is a performance bug. No correctness implications.
Assignee: general → gal
Attachment #417571 - Flags: review?(dvander)
make sure the nanojit parts are checked into the right repo.
yeah, thanks for the reminder
The addition of addxovi/subxovi/mulxovi made it impossible for this problem to occur.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.