534781 - Testsuite: base64-encode atob() is broken

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[Ben Bucksch (:BenB)]

atob() (base64-encode) in mailnews/test/resources/mailTestUtils.js is broken
(btoa() works):
atob(btoa(plain)) == plain
fails with "116101115116116101115116116101115116" != "testtesttest"

Attaching fix. Thanks to jcranmer (author) for the pointer.

Comment 1

[Ben Bucksch (:BenB)]

Attachment: Fix, v1

Comment 2

[Ben Bucksch (:BenB)]

Comment on attachment 417599 [details] [diff] [review]
Fix, v1

standard8, please r and/or sr. Should be straight-forward.

Comment 3

[Ben Bucksch (:BenB)]

For silly testing:
http://www.opinionatedgeek.com/dotnet/tools/Base64Decode/Default.aspx
http://www.opinionatedgeek.com/dotnet/tools/Base64Encode/Default.aspx

Comment 4

[Joshua Cranmer [:jcranmer]]

Comment on attachment 417599 [details] [diff] [review]
Fix, v1

If it works...

Comment 5

[Ben Bucksch (:BenB)]

http://hg.mozilla.org/users/mozilla.BenB_bucksch.org/mail-auth/rev/ab72d03c050b

Waiting for sr...

Comment 6

[Ben Bucksch (:BenB)]

remind self: commit

Comment 7

[Ben Bucksch (:BenB)]

Commited to comm-central trunk:
<http://hg.mozilla.org/comm-central/rev/69c6658a1102>
FIXED

Comment 8

[Mark Banner (:standard8)]

Comment on attachment 417599 [details] [diff] [review]
Fix, v1

Although we're not really dependent on this on the 3.0.x branch at the moment, I'd feel safer for taking it onto that branch in case a test relies on it later.

Comment 9

[Mark Banner (:standard8)]

Checked in on 1.9.1 branch: http://hg.mozilla.org/releases/comm-1.9.1/rev/cbd498a1b922

Comment 10

[Mark Banner (:standard8)]

Verifying on 3.0 as the patch has landed on branch and the tests are passing (plus this is a test-only bug).