The default bug view has changed. See this FAQ.

Testsuite: base64-encode atob() is broken

RESOLVED FIXED in Thunderbird 3.1b1

Status

MailNews Core
Backend
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: BenB, Assigned: BenB)

Tracking

Trunk
Thunderbird 3.1b1
Bug Flags:
in-testsuite +

Thunderbird Tracking Flags

(thunderbird3.0 .5-fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
atob() (base64-encode) in mailnews/test/resources/mailTestUtils.js is broken
(btoa() works):
atob(btoa(plain)) == plain
fails with "116101115116116101115116116101115116" != "testtesttest"

Attaching fix. Thanks to jcranmer (author) for the pointer.
(Assignee)

Comment 1

7 years ago
Created attachment 417599 [details] [diff] [review]
Fix, v1
Attachment #417599 - Flags: review?(Pidgeot18)
(Assignee)

Comment 2

7 years ago
Comment on attachment 417599 [details] [diff] [review]
Fix, v1

standard8, please r and/or sr. Should be straight-forward.
Attachment #417599 - Flags: superreview?(bugzilla)
(Assignee)

Comment 3

7 years ago
For silly testing:
http://www.opinionatedgeek.com/dotnet/tools/Base64Decode/Default.aspx
http://www.opinionatedgeek.com/dotnet/tools/Base64Encode/Default.aspx
Comment on attachment 417599 [details] [diff] [review]
Fix, v1

If it works...
Attachment #417599 - Flags: review?(Pidgeot18) → review+
(Assignee)

Comment 5

7 years ago
http://hg.mozilla.org/users/mozilla.BenB_bucksch.org/mail-auth/rev/ab72d03c050b

Waiting for sr...
Attachment #417599 - Flags: superreview?(bugzilla) → superreview+
(Assignee)

Comment 6

7 years ago
remind self: commit
(Assignee)

Comment 7

7 years ago
Commited to comm-central trunk:
<http://hg.mozilla.org/comm-central/rev/69c6658a1102>
FIXED
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
status-thunderbird3.0: --- → ?
Flags: in-testsuite+
Target Milestone: --- → Thunderbird 3.1b1
Version: 1.9.1 Branch → Trunk
Comment on attachment 417599 [details] [diff] [review]
Fix, v1

Although we're not really dependent on this on the 3.0.x branch at the moment, I'd feel safer for taking it onto that branch in case a test relies on it later.
Attachment #417599 - Flags: approval-thunderbird3.0.5+
status-thunderbird3.0: ? → wanted
Checked in on 1.9.1 branch: http://hg.mozilla.org/releases/comm-1.9.1/rev/cbd498a1b922
status-thunderbird3.0: wanted → .5-fixed
Verifying on 3.0 as the patch has landed on branch and the tests are passing (plus this is a test-only bug).
Keywords: verified-thunderbird3.0
You need to log in before you can comment on or make changes to this bug.