534788 - Make USE_WIN_SURFACE runtime switchable

Status: RESOLVED INVALID

(Core :: Graphics: ImageLib, defect)

Description

[Bas Schouten (:bas.schouten)]

In libpr0n's imgFrame USE_WIN_SURFACES is currently a #define. For D2D we don't want this to be used though, and we want to be able to switch to D2D based on a pref. Therefor windows surface usage should not be compile time switched.

Comment 1

[Joe Drew (not getting mail)]

Attachment: make USE_WIN_SURFACE a global variable

Comment 2

[Joe Drew (not getting mail)]

Attachment: make USE_WIN_SURFACE a global variable v2

The previous patch a) didn't compile and b) wasn't really that good anyways. Here's a better one.

Comment 3

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 418234 [details] [diff] [review]
make USE_WIN_SURFACE a global variable v2

We should be able to just test the global in ShouldUseImageSurface() and avoid change the preprocessor define and all that other code churn.

Comment 4

[Joe Drew (not getting mail)]

Attachment: Keep USE_WIN_SURFACE; add a global variable controlling it

Address comments; makes this patch much simpler.

Comment 5

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

why is that variable not controlled by the render mode?

Comment 6

[Joe Drew (not getting mail)]

It will be, eventually. Probably as a follow-up to this patch.

Comment 7

[Bas Schouten (:bas.schouten)]

As jrmuizel suggested, a better way is to use the ShouldUseImageSurfaces function which is already around. And the easiest way is to check the RenderMode from there directly, without a global. The D2D bug 527707 now contains a patch that does this.