534943 - Clean up the makefiles in lib/ckfw/builtins

Status: RESOLVED FIXED

(NSS :: Build, defect)

Description

[Wan-Teh Chang]

Attachment: Proposed patch

The current makefiles in lib/ckfw/builtins work, but they're
using the EXTRA_LIBS/EXTRA_SHARED_LIBS variables differently
from the makefiles for the other NSS shared libraries.

It would be nice for the makefiles for all shared libraries
to be consistent.

The attached patch does the following.

1. Use EXTRA_SHARED_LIBS instead of EXTRA_LIBS to specify
the NSPR shared libraries.  EXTRA_SHARED_LIBS is the variable
we use in the makefiles for other NSS shared libraries.  See
lib/nss/config.mk, lib/smime/config.mk, and lib/ssl/config.mk.

2. Remove obsolete makefile code for AIX 4.1 and 4.2.

3. Remove commented-out code.

Comment 1

[Christophe Ravel]

Comment on attachment 417742 [details] [diff] [review]
Proposed patch

r=Christophe

Comment 2

[Wan-Teh Chang]

I checked in the patch on the NSS trunk (NSS 3.12.6).

Checking in Makefile;
/cvsroot/mozilla/security/nss/lib/ckfw/builtins/Makefile,v  <--  Makefile
new revision: 1.20; previous revision: 1.19
done
Checking in manifest.mn;
/cvsroot/mozilla/security/nss/lib/ckfw/builtins/manifest.mn,v  <--  manifest.mn
new revision: 1.11; previous revision: 1.10
done