534992 - UnboundLocalError: local variable 'cleanroot' referenced before assignment in toolkit/crashreporter/tools/symbolstore.py

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, defect)

Description

[Bob Clary [:bc] (inactive)]

$ make buildsymbols
echo building symbol store
building symbol store
rm -f -rf ./dist/crashreporter-symbols
rm -f -f "./dist/firefox-3.5.7pre.en-US.mac.crashreporter-symbols.zip"
/work/mozilla/builds/1.9.1/mozilla/firefox-debug/config/nsinstall -D ./dist/crashreporter-symbols
/usr/bin/python /work/mozilla/builds/1.9.1/mozilla/toolkit/crashreporter/tools/symbolstore.py \
	  -a i386 --vcs-info                                          \
	  -s /work/mozilla/builds/1.9.1/mozilla               \
	  ./dist/host/bin/dump_syms                                                \
	  ./dist/crashreporter-symbols                                   \
	  ./dist/bin >                                        \
	  ./dist/crashreporter-symbols/firefox-3.5.7pre-Darwin-20091215131431-symbols.txt
Processing file: ./dist/bin/BadPlugin.dSYM
2009-12-15 14:22:54.883 dump_syms[26510:613] Loading DWARF dSYM file from /work/mozilla/builds/1.9.1/mozilla/firefox-debug/dist/bin/BadPlugin.dSYM/Contents/Resources/DWARF/BadPlugin
Unexpected error:  <type 'exceptions.UnboundLocalError'>
Traceback (most recent call last):
  File "/work/mozilla/builds/1.9.1/mozilla/toolkit/crashreporter/tools/symbolstore.py", line 755, in <module>
    main()
  File "/work/mozilla/builds/1.9.1/mozilla/toolkit/crashreporter/tools/symbolstore.py", line 751, in main
    dumper.Process(arg)
  File "/work/mozilla/builds/1.9.1/mozilla/toolkit/crashreporter/tools/symbolstore.py", line 462, in Process
    return self.ProcessDir(file_or_dir)
  File "/work/mozilla/builds/1.9.1/mozilla/toolkit/crashreporter/tools/symbolstore.py", line 479, in ProcessDir
    if not self.ProcessFile(fullpath):
  File "/work/mozilla/builds/1.9.1/mozilla/toolkit/crashreporter/tools/symbolstore.py", line 707, in ProcessFile
    res = Dumper.ProcessFile(self, dsymbundle)
  File "/work/mozilla/builds/1.9.1/mozilla/toolkit/crashreporter/tools/symbolstore.py", line 528, in ProcessFile
    (filename, rootname) = GetVCSFilename(filename, self.srcdirs)
  File "/work/mozilla/builds/1.9.1/mozilla/toolkit/crashreporter/tools/symbolstore.py", line 361, in GetVCSFilename
    fileInfo = HGFileInfo(file, srcdir)
  File "/work/mozilla/builds/1.9.1/mozilla/toolkit/crashreporter/tools/symbolstore.py", line 294, in __init__
    HGRepoInfo.repos[srcdir] = HGRepoInfo(path, rev, cleanroot)
UnboundLocalError: local variable 'cleanroot' referenced before assignment
make: *** [buildsymbols] Error 1

works with make buildsymbols SYM_STORE_SOURCE_DIRS=

Comment 1

[Mark Banner (:standard8)]

This typically happens when your source directory isn't cloned directly from the web based repository (e.g. http://hg.mozilla.org/) but from a clone of a local directory.

From looking at the script, specifying SRCSRV_ROOT would be better, but having an overall better error message would be good.

e.g. something like "This is either not a clone of the web based repository, or you have not specified the SRCSRV_ROOT variable" would cover some cases (although I've also seen it when hg can't actually be run).

Comment 2

[(not currently active) Ted Mielczarek]

symbolstore.py should just handle this case properly, when the upstream repo isn't http. It uses this regex:
http://mxr.mozilla.org/mozilla-central/source/toolkit/crashreporter/tools/symbolstore.py#196
http://mxr.mozilla.org/mozilla-central/source/toolkit/crashreporter/tools/symbolstore.py#290

Comment 4

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: m534992.patch

We see this error for clone failures, too, e.g., bug 695914.  This patch fixes the glaring Python error, replacing it with a better error message that (hopefully) covers all of the possibilities.

This specifically does *not* address your suggestion in the previous comment to handle the broken case in this bug.  That fix is over my head.  If you'd like, I'll be happy to move this patch back to 695914, since that's about all it fixes.

>>> h = HGFileInfo('toolkit/crashreporter/tools/symbolstore.py', '/Users/dustin/tmp/mozilla-central')
Could not determine repo info for /Users/dustin/tmp/mozilla-central.  This is either not a clone of the web-based
repository, or you have not specified SRCSRV_ROOT, or the clone is corrupt.
dustin@lorentz ~/tmp/mozilla-central $

Comment 5

[(not currently active) Ted Mielczarek]

Comment on attachment 568260 [details] [diff] [review]
m534992.patch

Review of attachment 568260 [details] [diff] [review]:
-----------------------------------------------------------------

This is better than the existing error, so that's fine. It would probably be nice to handle this case usefully, but I guess 99% of the time when this is being run it's on RelEng systems, and you'd rather get the error than have some incorrect fallback anyway.

Comment 6

[John Ford [:jhford] CET/CEST Berlin Time]

Dustin, still driving this?  I just hit this error due to cloning from another repo on disk instead of from hgweb and had to debug this a second time.  If the only thing left to do here is to push the r+'d patch to mozilla-inbound, I can do that.

Comment 7

[Dustin J. Mitchell [:dustin] (he/him)]

Please do - I just haven't gotten around to it yet.

Comment 8

[Chris Cooper [:coop] (he/him)]

Comment on attachment 568260 [details] [diff] [review]
m534992.patch

https://hg.mozilla.org/integration/mozilla-inbound/rev/9fdd1e53e1d0

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9fdd1e53e1d0

Coop - bugs typically aren't marked as fixed until they land on m-c.