Closed
Bug 535044
Opened 15 years ago
Closed 11 years ago
NJ_STACK_GROWTH_UP is stale and should be fixed or removed
Categories
(Core Graveyard :: Nanojit, enhancement)
Core Graveyard
Nanojit
Tracking
(Not tracked)
RESOLVED
WONTFIX
Future
People
(Reporter: stejohns, Unassigned)
Details
(Whiteboard: fixed-in-tamarin,fixed-in-nanojit)
Attachments
(1 obsolete file)
Quoth Edwin: "it was there for Thumb, which positioned EBP at the other end of the stack frame so load/stores could use positive offsets"
Thumb is gone, no current targets need it, and it's known to be broken. We should either fix it (and add some way to test it) or just remove it.
|
||
Comment 1•15 years ago
|
||
I vote for removal!
|
Reporter | |
Comment 2•15 years ago
|
||
Attachment #418674 -
Flags: review?(nnethercote)
|
|
||
Comment 3•15 years ago
|
||
Comment on attachment 418674 [details] [diff] [review]
Remove it
Looks good to me, but I'd like to run it past Andreas.
Attachment #418674 -
Flags: review?(nnethercote)
Attachment #418674 -
Flags: review?(gal)
Attachment #418674 -
Flags: review+
|
||
Comment 4•15 years ago
|
||
Comment on attachment 418674 [details] [diff] [review]
Remove it
Its definitely broken, so lets kill it.
Attachment #418674 -
Flags: review?(gal) → review+
|
||
Updated•15 years ago
|
Attachment #418674 -
Flags: review+
|
|
Reporter | |
Comment 5•15 years ago
|
||
Comment on attachment 418674 [details] [diff] [review]
Remove it
http://hg.mozilla.org/projects/nanojit-central/rev/0a12bb3f8436
Attachment #418674 -
Attachment is obsolete: true
|
|
Reporter | |
Comment 6•15 years ago
|
||
|
|
Reporter | |
Updated•15 years ago
|
Whiteboard: fixed-in-tamarin,fixed-in-nanojit
|
||
Updated•15 years ago
|
Component: JIT Compiler (NanoJIT) → Nanojit
Product: Tamarin → Core
QA Contact: nanojit → nanojit
Target Milestone: --- → Future
|
Assignee | |
Updated•11 years ago
|
Product: Core → Core Graveyard
|
|
||
Comment 7•11 years ago
|
||
Nanojit has been dead for several years. Its Bugzilla component has been moved to the graveyard (bug 984276).
I checked all the open bugs. They're all uninteresting, so I'm WONTFIXing them all. Apologies for the bugspam.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•