NJ_STACK_GROWTH_UP is stale and should be fixed or removed

RESOLVED WONTFIX

Status

--
enhancement
RESOLVED WONTFIX
9 years ago
5 years ago

People

(Reporter: stejohns, Unassigned)

Tracking

unspecified
Future

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fixed-in-tamarin,fixed-in-nanojit)

Attachments

(1 obsolete attachment)

(Reporter)

Description

9 years ago
Quoth Edwin: "it was there for Thumb, which positioned EBP at the other end of the stack frame so load/stores could use positive offsets"

Thumb is gone, no current targets need it, and it's known to be broken. We should either fix it (and add some way to test it) or just remove it.
I vote for removal!
(Reporter)

Comment 2

9 years ago
Created attachment 418674 [details] [diff] [review]
Remove it
Attachment #418674 - Flags: review?(nnethercote)
Comment on attachment 418674 [details] [diff] [review]
Remove it

Looks good to me, but I'd like to run it past Andreas.
Attachment #418674 - Flags: review?(nnethercote)
Attachment #418674 - Flags: review?(gal)
Attachment #418674 - Flags: review+

Comment 4

9 years ago
Comment on attachment 418674 [details] [diff] [review]
Remove it

Its definitely broken, so lets kill it.
Attachment #418674 - Flags: review?(gal) → review+

Updated

9 years ago
Attachment #418674 - Flags: review+
(Reporter)

Updated

9 years ago
Whiteboard: fixed-in-tamarin,fixed-in-nanojit

Updated

9 years ago
Component: JIT Compiler (NanoJIT) → Nanojit
Product: Tamarin → Core
QA Contact: nanojit → nanojit
Target Milestone: --- → Future
(Assignee)

Updated

5 years ago
Component: Nanojit → Nanojit
Product: Core → Core Graveyard
Nanojit has been dead for several years. Its Bugzilla component has been moved to the graveyard (bug 984276).

I checked all the open bugs. They're all uninteresting, so I'm WONTFIXing them all. Apologies for the bugspam.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.