53528 - ALT+HANKAKU/ZENKAKU key often activates menu bar

Status: VERIFIED FIXED

(Core :: Internationalization, defect, P2)

Description

[Masaki Katakai]

ALT+HANKAKU/ZENKAKU enables IME. However, ALT+HANKAKU/ZENKAKU combination
often activates menu bar on Mozilla. So menu bar will grab key event
while composing. For example, return key should move to next line, but
it will show File menu because menubar is active. It seems that it depends
on timing, however, on Notepad, I can not see this problem.
On Mozilla, the same operation often activates menu bar.
It's very serious for IME.

Comment 1

[sairuh (rarely reading bugmail)]

over to i18n...

Comment 2

[nhottanscp]

Reassign to Frank.

Comment 3

[Frank Tang]

reassign to shanjian. shanjian, please investigate.

Comment 4

[Koike Kazuhiko]

Please give this a high priority.

Comment 5

[Teruko Kobayashi]

*** Bug 55124 has been marked as a duplicate of this bug. ***

Comment 6

[Teruko Kobayashi]

Nominating this for RTM.

Comment 7

[Teruko Kobayashi]

This is Windows problem.

Comment 8

[Frank Tang]

This can only be reproduce if you release the ALT key first . mark this as rtm-

Comment 9

[Koike Kazuhiko]

Users release two keys at the same time, but the release of Alt key
often delays. It should be allowed.

Comment 10

[Roy Yokoyama]

I think I have a fix for this.  Frank: can you verify the fix?

Comment 11

[Shanjian Li]

reassign this bug to roy. He seems working on the problem. 
Roy, if you have a fix at hand, please post it into this bug report as 
attachment.

Comment 12

[Jaime Rodriguez, Jr.]

FTang - Why are we working on this, if it P3 and RTM-?

Comment 13

[Roy Yokoyama]

Attachment: Here is the patch. I hope the attachment works.( i never attached a file before.)

Comment 14

[Frank Tang]

sr=ftang [rtm need info]. I think we should take this bug. This cause a lot of 
usability issue for Japanese user. The fix seems safe and easy.
roy- please put more info into this bug report.

Comment 15

[Shanjian Li]

I do not see any problem with roy's fix. Alt+hankaku/zenkaku is triggered by keydown message, and 
menu item is trigger by either keyup or key pressed (it makes no difference here). As long as we can
receive the notification message in time, the problem should be fixed. r=shanjian

Comment 16

[Frank Tang]

mark it as rtm+

Comment 17

[Roy Yokoyama]

Impact assessment: minimal
The change only affect the IME message handling.  No impact
on plain latin base system.  WM_IME_NOTIFY msg will get sent
to application only if you have IME installed in the system.

Here is the psuedo code:
- PRBool mIMEIsStatusChanged is defined in nsWindows class and
  initialized to be PR_FALSE in the constructor.
- mIMEIsStatusChanged is PR_TRUE if and only if application
  receives WM_IME_NOTIFY status change msg + <Alt> key
- application will let WM_SYSKEYDOWN msg to fall through
  if and only if <Alt> and mIMEIsStatusChanged==PR_TRUE

Comment 18

[Michael La Guardia]

There's a super review here but not a review.  Could you please get a separate
review and then re-nominate?  Marking need info

Comment 19

[Roy Yokoyama]

Review was done by Shanjian Li 2000-10-10 16:17 after Frank's super-review.
(Usually the review is done first and then the super-review. Sorry for the
confusion.)  Re-nominating.

Comment 20

[Roy Yokoyama]

The fix is in both Trunk and Branch.  Please verify.
What to test:
-<Alt> key combination on all OS.  (eg. <Alt>+<~> to toggle IME-J)
-<Alt> key functionality in general.

Comment 21

[Teruko Kobayashi]

I verified this in 2000-10-12-12 branch build.