535359 - "Already loading" and "not loading" errors thrown

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Benjamin Stover (:stechz)]

STR: Go to cnn.co (typo intentional) and you will see the "server not found" page.

Unexpected result: error console has two errors that come from startLoading and endLoading.

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

And additional symptom of this bug is that the tab thumbnail of the page is not updated and represent the previous web page.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

We were passing back the windowID of the webProgress.DOMWindow and using it as the browser.contentWindowId. That is _not_ what we should be doing.

The webProgress.DOMWindow can be anything on the webpage. We should be sending back the content windowID for setting the browser.contentWindowId.

The webprogress system was getting messed up trying to keep track of which window was starting and stopping - and we were throwing the "loading" errors.

The patch passing back windowIDs for both the webProgress.DOMWindow and the content. We now only use the content windowID to set browser.contentWindowId

I haven't seen a "loading" error so far with this patch. I can easily reproduce the error without the patch.

All browser-chrome tests pass.

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 494947 [details] [diff] [review]
patch

Old bug fixing! wooot

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
http://hg.mozilla.org/mobile-browser/rev/e6b1289734ac

Comment 6

[Cristian Nicolae (:xti)]

Attachment: screenshot

The following errors occurs when I'm tapping quick on back and forward arrows for several times:

Error: uncaught exception: Already Loading!

Error: uncaught exception: Not Loading!

The involved websites are: http://people.mozilla.com/~tchung/html_tp/listlinks.html and http://vingtetun.org/todo (opened in the same tab).
Is this issue related to this bug?

Build id : Mozilla/5.0 (Android;Linux armv7l;rv:7.0a2)Gecko/20110717
Firefox/7.0a2 Fennec/7.0a2
Device: Motorola Droid 2
OS: Android 2.2

Comment 7

[Catalin Suciu [:csuciu]]

(In reply to Cristian Nicolae (:xti) from comment #6)
> Created attachment 546497 [details]
> screenshot
> 
> The following errors occurs when I'm tapping quick on back and forward
> arrows for several times:
> 
> Error: uncaught exception: Already Loading!
> 
> Error: uncaught exception: Not Loading!
> 
> The involved websites are:
> http://people.mozilla.com/~tchung/html_tp/listlinks.html and
> http://vingtetun.org/todo (opened in the same tab).
> Is this issue related to this bug?
> 
> Build id : Mozilla/5.0 (Android;Linux armv7l;rv:7.0a2)Gecko/20110717
> Firefox/7.0a2 Fennec/7.0a2
> Device: Motorola Droid 2
> OS: Android 2.2

I wasn't able to reproduce neither the initial issue nor the problem from comment #6.

Cristian, can you still reproduce this on the latest nightly?

Mozilla/5.0 (Android;Linux armv7l;rv:9.0a1)Gecko/20110927
Firefox/9.0a1 Fennec/9.0a1
Device: HTC Desire
OS: Android 2.2

Comment 8

[Cristian Nicolae (:xti)]

(In reply to Catalin Suciu from comment #7)
> (In reply to Cristian Nicolae (:xti) from comment #6)
> > Created attachment 546497 [details]
> > screenshot
> > 
> 
> I wasn't able to reproduce neither the initial issue nor the problem from
> comment #6.
> 
> Cristian, can you still reproduce this on the latest nightly?
> 
> Mozilla/5.0 (Android;Linux armv7l;rv:9.0a1)Gecko/20110927
> Firefox/9.0a1 Fennec/9.0a1
> Device: HTC Desire
> OS: Android 2.2

It seems that this issue is not reproducing on the latest nightly build. I guess this bug may be closed now.

--
Mozilla/5.0 (Android;Linux armv7l;rv:10.0a1)Gecko/20110928
Firefox/10.0a1 Fennec/10.0a1
Device: Samsung Galaxy S
OS: Android 2.2

Comment 9

[Catalin Suciu [:csuciu]]

Closing per comment #8