535383 - make statusbarpanels 16px high

Status: RESOLVED FIXED

(Mozilla Labs :: Jetpack Prototype, defect)

Description

[Myk Melez [:myk] [@mykmelez]]

Per discussion in bug 531950, we should make statusbarpanels a consistent 16px high on all OSes instead of a OS-specific height (f.e. 18px, 16px, and 22px on three common OSes).

Comment 1

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v1: makes it so

Comment 2

[Ed Lee :Mardak]

Comment on attachment 418049 [details] [diff] [review]
patch v1: makes it so

Padding change for better "balance"? How are the now-shorter iframes anchored on platforms that have more height?

Comment 3

[Myk Melez [:myk] [@mykmelez]]

Attachment: before and after screenshots

(In reply to comment #2)
> (From update of attachment 418049 [details] [diff] [review])
> Padding change for better "balance"?

Yeah, that particular change is Mac-only and is a hack to make the statusbarpanel background look better, since we're applying the background image for the statusbarpanel to the document inside the iframe inside it.  It still doesn't look perfect, but I realized that it's a bit better if we apply top padding to the iframe rather than bottom padding to the content document.


> How are the now-shorter iframes anchored on platforms that have more height?

Here are before and after screenshots for Windows XP, Mac OS X, and Linux.  Linux is much better, Windows seems the same, and Mac OS X is slightly better for the image case and slightly worse for the less-common text case.

Comment 4

[Ed Lee :Mardak]

Seems like the "stolen" mac-background for the iframe's content is 1px too low now. There's an extra white line above the "hi" in the "after" shot.

Comment 5

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v2: reverts Mac change

(In reply to comment #4)
> Seems like the "stolen" mac-background for the iframe's content is 1px too low
> now. There's an extra white line above the "hi" in the "after" shot.

Yeah, I'm just not sure what to do about that, so I've reverted that change for now.  Now Mac looks the same as before (which is also bad, as the image in the first panel overlaps its top border).

Comment 6

[Ed Lee :Mardak]

Comment on attachment 418049 [details] [diff] [review]
patch v1: makes it so

Personally I feel the first patch is better with the positioning. But Aza can make the call. If we do go with this one, we'll have a followup bug to fix the background issue.

Comment 7

[Myk Melez [:myk] [@mykmelez]]

(In reply to comment #6)
> (From update of attachment 418049 [details] [diff] [review])
> Personally I feel the first patch is better with the positioning. But Aza can
> make the call. If we do go with this one, we'll have a followup bug to fix the
> background issue.

I can make the call on this and have checked in the first patch in changeset http://hg.mozilla.org/labs/jetpack/rev/dab7edb86138.

I filed bug 535482 on the text panel regression.

Comment 8

[Aza Raskin [:aza]]

A late agreement with both Mardak and Myk that the first patch looks better.