535396 - Direct2d builds have slow menus on some machines.

Status: NEW

(Core :: Graphics, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

I have some timing code that should allow us to quantify the effect, I need a patch for d2d to try it out.

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Here are some times:

Before D2D

DoneMenu 0.036
DoneMenu 0.059
DoneMenu 0.071
DoneMenu 0.048
DoneMenu 0.052
DoneMenu 0.039
DoneMenu 0.024
DoneMenu 0.056
DoneMenu 0.055
DoneMenu 0.041
DoneMenu 0.072
DoneMenu 0.054
DoneMenu 0.042
DoneMenu 0.071
DoneMenu 0.044
DoneMenu 0.04
DoneMenu 0.045
DoneMenu 0.043
DoneMenu 0.051
DoneMenu 0.06
DoneMenu 0.073
DoneMenu 0.049
DoneMenu 0.043
DoneMenu 0.063
DoneMenu 0.055
DoneMenu 0.046
DoneMenu 0.038
DoneMenu 0.051
DoneMenu 0.05
DoneMenu 0.059
DoneMenu 0.061
DoneMenu 0.042
DoneMenu 0.077


After D2D

DoneMenu paint 0.05, total: 0.126
DoneMenu paint 0.03, total: 0.09
DoneMenu paint 0.015, total: 0.102
DoneMenu paint 0.02, total: 0.084
DoneMenu paint 0.012, total: 0.086
DoneMenu paint 0.019, total: 0.076
DoneMenu paint 0.043, total: 0.112
DoneMenu paint 0.032, total: 0.106
DoneMenu paint 0.016, total: 0.065
DoneMenu paint 0.019, total: 0.08
DoneMenu paint 0.018, total: 0.076
DoneMenu paint 0.024, total: 0.074
DoneMenu paint 0.023, total: 0.085
DoneMenu paint 0.019, total: 0.065
DoneMenu paint 0.04, total: 0.075
DoneMenu paint 0.05, total: 0.13
DoneMenu paint 0.025, total: 0.097
DoneMenu paint 0.013, total: 0.079
DoneMenu paint 0.019, total: 0.105
DoneMenu paint 0.04, total: 0.13
DoneMenu paint 0.043, total: 0.117
DoneMenu paint 0.023, total: 0.082
DoneMenu paint 0.019, total: 0.065
DoneMenu paint 0.022, total: 0.08
DoneMenu paint 0.029, total: 0.094
DoneMenu paint 0.045, total: 0.118
DoneMenu paint 0.025, total: 0.091
DoneMenu paint 0.016, total: 0.103
DoneMenu paint 0.02, total: 0.08
DoneMenu paint 0.021, total: 0.112
DoneMenu paint 0.029, total: 0.109
DoneMenu paint 0.039, total: 0.105
DoneMenu paint 0.043, total: 0.117
DoneMenu paint 0.022, total: 0.073

Comment 2

[Jeff Muizelaar [:jrmuizel]]

Here are some broken out times for gdi:
DoneMenu paint 0.004, total: 0.048
DoneMenu paint 0.005, total: 0.042
DoneMenu paint 0.005, total: 0.055
DoneMenu paint 0.006, total: 0.051
DoneMenu paint 0.005, total: 0.074
DoneMenu paint 0.003, total: 0.049
DoneMenu paint 0.007, total: 0.06
DoneMenu paint 0.005, total: 0.045
DoneMenu paint 0.004, total: 0.049
DoneMenu paint 0.003, total: 0.052
DoneMenu paint 0.009, total: 0.082
DoneMenu paint 0.004, total: 0.053
DoneMenu paint 0.004, total: 0.062
DoneMenu paint 0.002, total: 0.026
DoneMenu paint 0.004, total: 0.046
DoneMenu paint 0.003, total: 0.038
DoneMenu paint 0.005, total: 0.036
DoneMenu paint 0.004, total: 0.063
DoneMenu paint 0.004, total: 0.049
DoneMenu paint 0.004, total: 0.05
DoneMenu paint 0.005, total: 0.045
DoneMenu paint 0.003, total: 0.044
DoneMenu paint 0.003, total: 0.023
DoneMenu paint 0.005, total: 0.063
DoneMenu paint 0.003, total: 0.037
DoneMenu paint 0.009, total: 0.068
DoneMenu paint 0.003, total: 0.04
DoneMenu paint 0.003, total: 0.021
DoneMenu paint 0.005, total: 0.056
DoneMenu paint 0.009, total: 0.072
DoneMenu paint 0.003, total: 0.051
DoneMenu paint 0.005, total: 0.072
DoneMenu paint 0.003, total: 0.043
DoneMenu paint 0.005, total: 0.065
DoneMenu paint 0.003, total: 0.045
DoneMenu paint 0.004, total: 0.041
DoneMenu paint 0.005, total: 0.044

This seems to imply painting takes longer on d2d.

Comment 3

[Jeff Muizelaar [:jrmuizel]]

It seems like this could be caused by us doing alpha recovery when doing native theme drawing

Comment 4

[Jeff Muizelaar [:jrmuizel]]

I wasn't able to get numbers to show the problem was caused by native theme drawing, however switching the native theme off (mozilla.widget.disable-native-theme") seemed to solve the problem.

Comment 5

[John Daggett (:jtd)]

According to Bas this can be dealt with after the main patch lands.