Closed
Bug 535408
Opened 15 years ago
Closed 15 years ago
Increase Sessionstore interval to 15s
Categories
(Firefox :: Session Restore, defect)
Firefox
Session Restore
Tracking
()
VERIFIED
FIXED
Firefox 3.7a1
People
(Reporter: zpao, Assigned: zpao)
References
Details
(Whiteboard: [tsnap])
Attachments
(2 files)
|
1.14 KB,
patch
|
dietrich
:
review+
|
Details | Diff | Splinter Review |
|
893 bytes,
patch
|
dietrich
:
review+
|
Details | Diff | Splinter Review |
Per discussion with dietrich & mconnor, changing the default interval to 15s and not saving for readonly events will significantly reduce the number of writes to disk we do (33+% fewer) without any real loss of functionality.
|
||
Updated•15 years ago
|
Whiteboard: [tsnap]
|
Assignee | |
Comment 1•15 years ago
|
||
Attachment #418232 -
Flags: review?(dietrich)
|
|
||
Updated•15 years ago
|
Attachment #418232 -
Flags: review?(dietrich) → review+
|
|
Assignee | |
Comment 2•15 years ago
|
||
Pushed http://hg.mozilla.org/mozilla-central/rev/314597526cbf
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•15 years ago
|
Target Milestone: --- → Firefox 3.7a1
|
|
Assignee | |
Comment 3•15 years ago
|
||
Hmm, I forgot to change the default value in nsSessionStore.js. It doesn't really matter though since the pref is read at initialization, but we should probably keep those in sync.
|
|
Assignee | |
Comment 4•15 years ago
|
||
Change the default interval in nsSessionStore.js too (in case the pref is deleted from firefox.js)
Attachment #421492 -
Flags: review?(dietrich)
|
|
||
Updated•15 years ago
|
Attachment #421492 -
Flags: review?(dietrich) → review+
|
|
Assignee | |
Comment 5•15 years ago
|
||
Pushed Part 2: http://hg.mozilla.org/mozilla-central/rev/daef0c74edfe
Verified by checking nsSessionStore.js, about:config, and firefox.js.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•