535538 - searchplugins cannot be found if chrome:// search engine loading is used with flat chrome

Status: RESOLVED FIXED

(Firefox :: Search, defect)

Description

[Wolfgang Rosenauer [:wolfiR]]

While this is an edge case and proper release builds shouldn't be shipped in flat chrome format I wouldn't expect stuff to break as it's a valid build option.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

The same thing is true when running a build with omnijar packaging. Before packaging, omnijar just uses flat files for staging, so running a build will fail to load the search engines.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

This patch assumes we have a JAR URI, but will fallback to assume we have a File URI, which is the case for flat or omni packaging.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

This fix becomes more important as mobile swithces over to use omnijar packaging for Maemo (bug 608742)

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 487524 [details] [diff] [review]
patch

I'd just write it as:
let chromeURI = gChromeReg.convertChromeURL(makeURI(root));
let fileURI = chromeURI; // flat packaging
if (fileURI instanceof Ci.nsIJARURI)
  fileURI = fileURI.JARFile; // JAR packaging

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #4)

> I'd just write it as:
> let chromeURI = gChromeReg.convertChromeURL(makeURI(root));
> let fileURI = chromeURI; // flat packaging
> if (fileURI instanceof Ci.nsIJARURI)
>   fileURI = fileURI.JARFile; // JAR packaging

Yeah, better

This blocks a fennec blocker (bug 608742)

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
http://hg.mozilla.org/mozilla-central/rev/f3dcdd8686ff