Closed Bug 535538 Opened 13 years ago Closed 12 years ago

searchplugins cannot be found if chrome:// search engine loading is used with flat chrome

Categories

(Firefox :: Search, defect)

ARM
Maemo
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: wolfiR, Assigned: mfinkle)

References

Details

Attachments

(1 file)

While this is an edge case and proper release builds shouldn't be shipped in flat chrome format I wouldn't expect stuff to break as it's a valid build option.
Component: Linux/Maemo → General
OS: Linux → Linux (embedded)
Hardware: All → ARM
The same thing is true when running a build with omnijar packaging. Before packaging, omnijar just uses flat files for staging, so running a build will fail to load the search engines.
Attached patch patchSplinter Review
This patch assumes we have a JAR URI, but will fallback to assume we have a File URI, which is the case for flat or omni packaging.
Assignee: nobody → mark.finkle
Attachment #487524 - Flags: review?(gavin.sharp)
This fix becomes more important as mobile swithces over to use omnijar packaging for Maemo (bug 608742)
Blocks: 608742
Comment on attachment 487524 [details] [diff] [review]
patch

I'd just write it as:
let chromeURI = gChromeReg.convertChromeURL(makeURI(root));
let fileURI = chromeURI; // flat packaging
if (fileURI instanceof Ci.nsIJARURI)
  fileURI = fileURI.JARFile; // JAR packaging
Attachment #487524 - Flags: review?(gavin.sharp) → review+
Component: General → Search
Product: Fennec → Firefox
QA Contact: maemo-linux → search
Summary: searchplugins cannot be found if flat chrome format is used → searchplugins cannot be found if chrome:// search engine loading is used with flat chrome
Version: 1.9.2 Branch → Trunk
(In reply to comment #4)

> I'd just write it as:
> let chromeURI = gChromeReg.convertChromeURL(makeURI(root));
> let fileURI = chromeURI; // flat packaging
> if (fileURI instanceof Ci.nsIJARURI)
>   fileURI = fileURI.JARFile; // JAR packaging

Yeah, better

This blocks a fennec blocker (bug 608742)
pushed:
http://hg.mozilla.org/mozilla-central/rev/f3dcdd8686ff
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.