535559 - [Regression] Special case fullscreen/maximized in resize handler

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: General, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

If we know we will be fullscreen/maximized, we can skip any resizes until we see a width that is the screen width.

This regressed when we added sizemode="fullscreen", previously it was sizemode="maximized"

Tested on N900

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 418169 [details] [diff] [review]
patch

>diff --git a/chrome/content/browser.js b/chrome/content/browser.js

>     function resizeHandler(e) {

>-      if (maximize && w > screen.width)

>+      // Special case the fullscreen/mximized mode. We only need to do the
>+      // resize code if we are at the final size.
>+      let sizemode = document.documentElement.getAttribute("sizemode");
>+      if (w != screen.width && (sizemode == "fullscreen" || sizemode == "maximized"))

I'm a bit worried that there are cases when screen.width will not be equal to w even with sizemode="fullscreen"/"maximized", which would result in us never resizing controls. Doesn't seem to happen on n900, but what about winmo or other devices?

nit: check sizemode before screen.width?

Comment 2

[:Gavin Sharp [email: [e-mail]]]

This patch causes a sizing glitch on startup on my n900. The window briefly displays at it's "default" size and then snaps back into place. I suppose this is because we're now resizing after displaying rather than before (i.e. resize event that takes effect is later). Not sure what the best tradeoff here is...

Comment 3

[Jeremias Bosch (:jbos)]

This patch is quite old, but since i'm just playing around in that area right now i want to add that this does not work with rotation.

Or am I wrong?

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

let's just close this bug