535590 - Mozilla build needs to support DirectX SDK in the future

Status: RESOLVED INVALID

(Firefox Build System :: MozillaBuild, task)

Description

[Bas Schouten (:bas.schouten)]

Attachment: Mozilla Build DX SDK support v1

For the Direct2D patches we need the DirectX SDK in case we want to build with DirectX support. Mozilla-build will need to add the relevant include patch. I've added a patch that does this.

Comment 1

[(not currently active) Ted Mielczarek]

Is DXSDK_DIR set in the system environment by the DX SDK installer?

Comment 2

[Bas Schouten (:bas.schouten)]

(In reply to comment #1)
> Is DXSDK_DIR set in the system environment by the DX SDK installer?

It is, atleast on all my machines it was. It's probably good to check on a machine that never had the DX SDK, but I'm 90% sure it is.

Comment 3

[Jeff Muizelaar [:jrmuizel]]

We don't need the DX SDK so we don't need this bug.

Comment 4

[Jens Hatlak (:InvisibleSmiley)]

(In reply to comment #3)
> We don't need the DX SDK so we don't need this bug.

Well, now we do. From https://developer.mozilla.org/En/Developer_Guide/Build_Instructions/Windows_Prerequisites:
"The DirectX SDK is required for building ANGLE"

There's already (configure?) check for d3dx9.h on m-c which is currently a warning but says that it might become mandatory in the future. The warning's advice that one should add the paths to INCLUDES and LIBS is a bit misleading since it must be added to the MozillaBuild start scripts (like the patch here does), not the equally named Windows environment variables (if set) which are just ignored.

-> Please revisit the decision about the status of this bug.

[Note: I find it strange that this problem doesn't seem to have been reported or commented on anywhere. Are people who compile Mozilla-based software on Windows expected to figure this out themselves? Or am I just not reading the right channels? FWIW I'm building on Win7 x64, VC9, PSDK 2003, 2010 Feb DX SDK.]

Comment 5

[(not currently active) Ted Mielczarek]

Vlad may be able to comment here. IIRC, he wasn't concerned about making ANGLE build on all systems without manual intervention.

Comment 6

[Jens Hatlak (:InvisibleSmiley)]

Hmm, I finally got around to actually testing this. With the 2010 Feb DX SDK installed and the patch applied to MozillaBuild, the compile stops here:

=== Building ANGLE via devenv.exe ===
Upgrading solution...
/bin/sh: line 5: devenv: command not found
make[6]: *** [libEGL.dll] Error 127
make[6]: Leaving directory `/e/mozilla-src/seamonkey-central/mozilla/gfx/angle'
make[5]: *** [libs] Error 2

I read that devenv.exe would normally be under C:\Program Files\Microsoft Visual Studio 9.0\Common7\IDE; I couldn't find that file on my whole C: drive. Seems like it's missing from VS9 SP1 Express.

Anyway, following the direction of this bug I decided to not test this any further and just uninstalled the DX SDK (which spares me adding --disable-angle).

Comment 7

[Bas Schouten (:bas.schouten)]

(In reply to comment #6)
> Hmm, I finally got around to actually testing this. With the 2010 Feb DX SDK
> installed and the patch applied to MozillaBuild, the compile stops here:
> 
> === Building ANGLE via devenv.exe ===
> Upgrading solution...
> /bin/sh: line 5: devenv: command not found
> make[6]: *** [libEGL.dll] Error 127
> make[6]: Leaving directory `/e/mozilla-src/seamonkey-central/mozilla/gfx/angle'
> make[5]: *** [libs] Error 2
> 
> I read that devenv.exe would normally be under C:\Program Files\Microsoft
> Visual Studio 9.0\Common7\IDE; I couldn't find that file on my whole C: drive.
> Seems like it's missing from VS9 SP1 Express.
> 
> Anyway, following the direction of this bug I decided to not test this any
> further and just uninstalled the DX SDK (which spares me adding
> --disable-angle).

Are you using Visual Studio Express? I seem to recall it doesn't call it devenv. You need to use msbuild directly I think, or something along those lines.

Comment 8

[Jens Hatlak (:InvisibleSmiley)]

(In reply to comment #7)
> Are you using Visual Studio Express?

Yes, as I wrote in comment 6 (granted, easy to miss).

> I seem to recall it doesn't call it devenv. You need to use msbuild directly
> I think, or something along those lines.

Thanks for your effort, but as I said I won't pursue this anymore (unless it becomes mandatory at some point in time).