Deleted properties' slots are not recycled

RESOLVED FIXED in mozilla2.0

Status

()

Core
JavaScript Engine
P2
normal
RESOLVED FIXED
8 years ago
7 years ago

People

(Reporter: jorendorff, Assigned: brendan)

Tracking

Other Branch
mozilla2.0
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

8 years ago
We could compact them during GC or keep a freelist threaded through the vacant slots.
(Assignee)

Updated

7 years ago
Assignee: general → brendan
Status: NEW → ASSIGNED
Depends on: 558451
Priority: -- → P2
Target Milestone: --- → mozilla2.0
(Assignee)

Comment 1

7 years ago
Created attachment 467027 [details] [diff] [review]
based on patch queue for bug 558451

No rush on review. Should be a relief to do this after recovery from bug 558451 patch queue review.

/be
Attachment #467027 - Flags: review?(jorendorff)
(Assignee)

Comment 2

7 years ago
Created attachment 467197 [details] [diff] [review]
rebased on latest mq for 558451 and tm tip
Attachment #467027 - Attachment is obsolete: true
Attachment #467197 - Flags: review?(jorendorff)
Attachment #467027 - Flags: review?(jorendorff)
(Assignee)

Updated

7 years ago
Blocks: 520293
(Assignee)

Comment 3

7 years ago
Created attachment 470506 [details] [diff] [review]
rebased to tm tip just now

Bite-sized, too!

/be
Attachment #467197 - Attachment is obsolete: true
Attachment #470506 - Flags: review?(jorendorff)
Attachment #467197 - Flags: review?(jorendorff)
(Assignee)

Comment 4

7 years ago
Comment on attachment 470506 [details] [diff] [review]
rebased to tm tip just now

Giving Jason a break again, and Andreas has always wanted to see this fixed, so...

/be
Attachment #470506 - Flags: review?(jorendorff) → review?(gal)

Comment 5

7 years ago
This duplicates some code that could be commoned out.

Updated

7 years ago
Attachment #470506 - Flags: review?(gal) → review+
(Assignee)

Comment 6

7 years ago
(In reply to comment #5)
> This duplicates some code that could be commoned out.

Andreas couldn't cite that code so I'm going with the patch as attached :-P.

/be
(Assignee)

Comment 7

7 years ago
http://hg.mozilla.org/tracemonkey/rev/cb719643afc5

/be
Whiteboard: fixed-in-tracemonkey
Depends on: 593580
Depends on: 595230
(Assignee)

Comment 8

7 years ago
http://hg.mozilla.org/mozilla-central/rev/cb719643afc5

/be
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.