535675 - Typing +foo in the QuickSearch box throws an "uninitialized value" warning (missing 'order' parameter)

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, defect)

Description

[Frédéric Buclin]

Use of uninitialized value in pattern match (m//) at /var/www/html/bugzilla-pg/buglist.cgi line 858.

$vars->{'message'} = 'buglist_sorted_by_relevance' if ($cgi->param('order') =~ /^relevance/);

'order' is undefined when called from QS. I cannot reproduce when using 3.4.4, so it seems something regressed this in 3.5. Marking as blocker as it's filling my error log.

Comment 1

[Teemu Mannermaa (:wicked)]

Looks like I noted this problem in bug 503806. Fixing that bug should fix this problem (use relevance sorting for QS).

Comment 2

[Frédéric Buclin]

Attachment: patch, v1

I disagree to sort by relevance when using QS, for the reason given there. So the right fix for now for this bug is to check if the 'order' parameter exists.

Comment 3

[Teemu Mannermaa (:wicked)]

This is also needed on 3.4 branch because I can reproduce same error by doing a content matches Advanced Search without specifying specific order.

Comment 4

[Frédéric Buclin]

tip:

Checking in buglist.cgi;
/cvsroot/mozilla/webtools/bugzilla/buglist.cgi,v  <--  buglist.cgi
new revision: 1.409; previous revision: 1.408
done

3.4.4:

Checking in buglist.cgi;
/cvsroot/mozilla/webtools/bugzilla/buglist.cgi,v  <--  buglist.cgi
new revision: 1.394.2.7; previous revision: 1.394.2.6
done