535693 - Display Live Chat ID on My Account when it differs from SUMO login

Status: RESOLVED FIXED

(support.mozilla.org :: Knowledge Base Software, task, P4)

Description

[James Socol [:jsocol, :james]]

Post-migration, when a Live Chat ID is different from the TikiWiki login, we should display that on the My Account page somewhere. (Read-only, of course.)

We could display it all the time, but I think it's only particularly important when it's different.

Comment 1

[Paul Craciunoiu [:paulc]]

Attachment: adds a livechat ID row, always displayed

This just displays it all the time, regardless of whether it is set or not.

It's worth noting that, after the automatic migration script, all accounts should have a livechat_id set, none should be NULL. The admin management should take care of the potential few cases where users don't have a livechat_id set.

Comment 2

[James Socol [:jsocol, :james]]

Why the change in behavior between comment 0 and comment 1? I might have forgotten, but I thought we talked about only displaying the livechat_id when it differed from the login?

Comment 3

[Paul Craciunoiu [:paulc]]

(In reply to comment #2)
> only displaying the livechat_id when it differed from the login?
We can do that, yeah. Change was just to keep the code simpler. Should the livechat ID row be hidden entirely, if it does not differ?

Comment 4

[James Socol [:jsocol, :james]]

Seems like the condition should be:

if($livechat_id && $livechat_id!=$login)

If the livechat_id is set, and not the login, display it.

Comment 5

[Paul Craciunoiu [:paulc]]

Attachment: v2, pasted james' code in comment 4

Take that! I practically pasted what you said :)

Comment 6

[James Socol [:jsocol, :james]]

Comment on attachment 418894 [details] [diff] [review]
v2, pasted james' code in comment 4

WFM. Thanks for the change!

Comment 7

[Paul Craciunoiu [:paulc]]

r59231
Testing livechat_id when registering on stage should now work. To see it displayed, register a user with spaces or punctuation (which would make livechat_id different from the user login). See bug 534340 for the registration.