nptest_windows.cpp fails to compile on mingw.

RESOLVED FIXED in mozilla1.9.3a1

Status

()

Core
Plug-ins
RESOLVED FIXED
9 years ago
8 years ago

People

(Reporter: Jacek Caban, Assigned: Jacek Caban)

Tracking

Trunk
mozilla1.9.3a1
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

9 years ago
Created attachment 418425 [details] [diff] [review]
fix

On current mingw nptest_windows.cpp is broken again. It's because sprintf is used without stdio.h include. On MSC #include <string> is enough, but not on new mingw. I'd usually prefer fixing mingw, but in this case I think that assumption that <string> includes <stdio.h> is bad and it should be fixed in mozilla.

The fix is attached.
(Assignee)

Updated

9 years ago
Attachment #418425 - Attachment is patch: true
Attachment #418425 - Flags: review?(roc)
(Assignee)

Updated

9 years ago
Assignee: nobody → jacek
(Assignee)

Updated

9 years ago
Keywords: checkin-needed
(Assignee)

Updated

8 years ago
Blocks: 421095
Pushed to m-c: http://hg.mozilla.org/mozilla-central/rev/adf1e404f264.
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a1
You need to log in before you can comment on or make changes to this bug.