Closed Bug 535872 Opened 15 years ago Closed 14 years ago

nptest_windows.cpp fails to compile on mingw.

Categories

(Core Graveyard :: Plug-ins, defect)

x86
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.9.3a1

People

(Reporter: jacek, Assigned: jacek)

References

Details

Attachments

(1 file)

Attached patch fixSplinter Review
On current mingw nptest_windows.cpp is broken again. It's because sprintf is used without stdio.h include. On MSC #include <string> is enough, but not on new mingw. I'd usually prefer fixing mingw, but in this case I think that assumption that <string> includes <stdio.h> is bad and it should be fixed in mozilla.

The fix is attached.
Attachment #418425 - Attachment is patch: true
Attachment #418425 - Flags: review?(roc)
Assignee: nobody → jacek
Keywords: checkin-needed
Blocks: 421095
Pushed to m-c: http://hg.mozilla.org/mozilla-central/rev/adf1e404f264.
Status: NEW → RESOLVED
Closed: 14 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a1
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: